Add prometheus exporter support to helm chart #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
isaachawley
reviewed
Jul 12, 2018
helm-chart/README.md
Outdated
| @@ -82,6 +82,11 @@ Parameter | Description | Default | |||
| `controller.watchNamespace` | Namespace to watch for Ingress resources. By default the Ingress controller watches all namespaces. | "" | |||
| `controller.healthStatus` | Add a location "/nginx-health" to the default server. The location responds with the 200 status code for any request. Useful for external health-checking of the Ingress controller. | false | |||
| `rbac.create` | Configures RBAC. | true | |||
| `prometheues.create` | Deploys a Prometheus exporter container within the Ingress controller pod. Requires NGINX Plus. `controller.nginxplus` must be set to `true` | false | |||
| `prometheus.port` | Configures the port to scrape the metrics | 9113 | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
helm-chart/README.md
Outdated
| `prometheus.port` | Configures the port to scrape the metrics | 9113 | ||
| `prometheus.image.repository` | The image repository of the Prometheus exporter. | nginx/nginx-prometheus-exporter | ||
| `prometheus.image.tag` | The tag of the Prometheus exporter image. | 0.1.0 | ||
| `prometheus.image.pullPolicy` | The pull policy for the Prometheus exporter image. | IfNotPresent |
There was a problem hiding this comment.
maybe drop all the "The"s. "Pull policy..."
Dean-Coakley
force-pushed
the
helm-prometheus-support
branch
4 times, most recently
from
475e2c3 to
22576ea
Compare
- Update helm chart documentation - Add prometheus support to daemonset and deployment templates
Dean-Coakley
force-pushed
the
helm-prometheus-support
branch
from
22576ea to
c40eeb7
Compare
isaachawley
approved these changes
Jul 13, 2018
pleshakov
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Prometheus exporter support to NGINX Plus Ingress Controller
Disabled by default.
Exporter image, repository and scraping port are configurable.
Minor chart version increment