Skip to content

Add VersionCheck and Metadata to Agent labels #7737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 15, 2025

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented May 2, 2025

Proposed changes

  • Add version check to see if it is Agent V2 or Agent V3
  • Add metadata on the deplyoment to send to Agent
  • Update deployment id to look for more than 1 pod and to return the name of the deployment if its not daemonset or replicaset

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner May 2, 2025 13:22
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code labels May 2, 2025
@AlexFenlon AlexFenlon linked an issue May 2, 2025 that may be closed by this pull request
5 tasks
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 36.36364% with 70 lines in your changes missing coverage. Please review.

Project coverage is 52.29%. Comparing base (c07da1c) to head (1170dc6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/nginx/manager.go 0.00% 27 Missing ⚠️
...nternal/common_cluster_info/common_cluster_info.go 0.00% 23 Missing ⚠️
internal/metadata/metadata.go 71.87% 6 Missing and 3 partials ⚠️
cmd/nginx-ingress/main.go 0.00% 8 Missing ⚠️
internal/nginx/version.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7737      +/-   ##
==========================================
- Coverage   52.34%   52.29%   -0.06%     
==========================================
  Files          89       90       +1     
  Lines       21373    21472      +99     
==========================================
+ Hits        11188    11228      +40     
- Misses       9719     9774      +55     
- Partials      466      470       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexFenlon AlexFenlon enabled auto-merge (squash) May 15, 2025 10:16
@AlexFenlon AlexFenlon requested a review from pdabelf5 May 15, 2025 12:25
@AlexFenlon AlexFenlon merged commit cf6521a into main May 15, 2025
30 checks passed
@AlexFenlon AlexFenlon deleted the feat/add-metadata-to-agent branch May 15, 2025 14:07
@AlexFenlon AlexFenlon removed the enhancement Pull requests for new features/feature enhancements label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide metadata for Agent labels
3 participants