[Bug]: golang:1.24 is required when building image for 4.0.1 version

[komalbhagavan]

Version

4.0.1

What Kubernetes platforms are you running on?

Kind

Steps to reproduce

The golang:1.23 is giving an issue when building the images , below is the error we are facing

#70 ERROR: process "/bin/sh -c go mod download" did not complete successfully: exit code: 1
------
 > [builder 3/4] RUN --mount=type=bind,target=/go/src/github.com/nginx/kubernetes-ingress/ --mount=type=cache,target=/root/.cache/go-build 	go mod download:
0.203 go: go.mod requires go >= 1.24.2 (running go 1.23.6; GOTOOLCHAIN=local)
------
ERROR: failed to build: failed to solve: process "/bin/sh -c go mod download" did not complete successfully: exit code: 1
make: *** [Makefile:148: alpine-image-plus-fips] Error 1```

So we need to update the FROM golang:1.23-alpine@sha256:2c49857f2295e89b23b28386e57e018a86620a8fede5003900f2d138ba9c4037 AS golang-builder
 in dockerfile

[github-actions]

Hi @komalbhagavan thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

[AlexFenlon]

Hi @komalbhagavan ,

The go version in 4.0.1 should be using go 1.23.5. You are using the version 1.23.6 so it should work.

Can you please upgrade your go version and try again

[komalbhagavan]

Hi @AlexFenlon.
The Go version is coming from this https://github.com/nginx/kubernetes-ingress/blob/v4.0.1/build/Dockerfile repo, right? I think you guys need to update your Docker file (line no. 20) . But for now, I have patched your Docker file(1.24.2 version) after cloning it in my pipeline and resolved the version mismatch issue.

Upon further investigation , However, even with Go 1.24.2, we are consistently encountering the following error during the go build step inside the Docker container:

internal/telemetry/collector.go:15:2: no required module provides package github.com/nginx/telemetry-exporter/pkg/telemetry; to add it: go get github.com/nginx/telemetry-exporter/pkg/telemetry

This indicates an inconsistency in vendoring/module resolution within the project's dependency graph as perceived by the Go build system, particularly concerning the telemetry-exporter module. Even when go mod tidy and go mod vendor are run on the host machine, the go build inside the Dockerfile still reports this missing module. (This same kind of issue we are facing in both 4.0.1 and 5.1.0 ).

To resolve this directly within the Docker build process, we suggest modifying the build/Dockerfile to explicitly ensure Go modules are correctly synced before compilation.
So please make the necessary changes to your Docker file (https://github.com/nginx/kubernetes-ingress/blob/v4.0.1/build/Dockerfile)

[AlexFenlon]

Hi @komalbhagavan ,

We actually get the goversion from here in the go.mod - https://github.com/nginx/kubernetes-ingress/blob/v4.0.1/go.mod#L3

We do also have telemetry exporter in our go.mod - https://github.com/nginx/kubernetes-ingress/blob/v4.0.1/go.mod#L17

For v5.1.0 we are using go v1.24.2 - https://github.com/nginx/kubernetes-ingress/blob/v5.1.0/go.mod#L3

Apogies for not understanding fully.

Can you please tell me what parmaters you are using in the make command so I can try replicate this?