Have the Dockerfile build from the actual surrounding sources rather than downloading a hardcoded version #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dockerfile now builds from the actual surrounding sources
jwilder
approved these changes
Apr 10, 2021
|
@jwilder unfortunately DockerHub can't do automated build for multiple archs. Do you want me to contribute a GitHub Actions worklow that will take care of that by building on GHA with buildx and pushing to DockerHub ? It'll only require that you create a token on DockerHub and add it to the GitHub repository's secrets. |
This was referenced Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I understand the rationale for downloading a hard coded version back when building the Go binary using multi stage Dockerfile wasn't an option, I think it's not relevant anymore and that the Dockerfile should build an image corresponding to the surrounding sources. We're currently in a strange situation where the project's Dockerfile potentially builds an image that use codes dating from a handful of commits back.
Having tagged versions of the container derived from git tags should happen through the CI instead (either GitHub Actions of DockerHub's autobuild). The version can still be passed to
go build -X main.buildVersionusing theVERSIONbuildARG.The resultant image has been tested with nginx-proxy and is working.