refactor: Replace requests_mock calls with responses

Author: edmundmiller

tests/modules/create.py

@@ -1,16 +1,16 @@
 import os
 
 import pytest
-import requests_mock
+import responses
 
 import nf_core.modules
 from tests.utils import mock_api_calls
 
 
 def test_modules_create_succeed(self):
     """Succeed at creating the TrimGalore! module"""
-    with requests_mock.Mocker() as mock:
-        mock_api_calls(mock, "trim-galore", "0.6.7")
+    with responses.RequestsMock() as rsps:
+        mock_api_calls(rsps, "trim-galore", "0.6.7")
         module_create = nf_core.modules.ModuleCreate(
             self.pipeline_dir, "trimgalore", "@author", "process_single", True, True, conda_name="trim-galore"
         )
@@ -20,8 +20,8 @@ def test_modules_create_succeed(self):
 
 def test_modules_create_fail_exists(self):
     """Fail at creating the same module twice"""
-    with requests_mock.Mocker() as mock:
-        mock_api_calls(mock, "trim-galore", "0.6.7")
+    with responses.RequestsMock() as rsps:
+        mock_api_calls(rsps, "trim-galore", "0.6.7")
         module_create = nf_core.modules.ModuleCreate(
             self.pipeline_dir, "trimgalore", "@author", "process_single", False, False, conda_name="trim-galore"
         )
@@ -33,8 +33,8 @@ def test_modules_create_fail_exists(self):
 
 def test_modules_create_nfcore_modules(self):
     """Create a module in nf-core/modules clone"""
-    with requests_mock.Mocker() as mock:
-        mock_api_calls(mock, "fastqc", "0.11.9")
+    with responses.RequestsMock() as rsps:
+        mock_api_calls(rsps, "fastqc", "0.11.9")
         module_create = nf_core.modules.ModuleCreate(
             self.nfcore_modules, "fastqc", "@author", "process_low", False, False
         )
@@ -45,8 +45,8 @@ def test_modules_create_nfcore_modules(self):
 
 def test_modules_create_nfcore_modules_subtool(self):
     """Create a tool/subtool module in a nf-core/modules clone"""
-    with requests_mock.Mocker() as mock:
-        mock_api_calls(mock, "star", "2.8.10a")
+    with responses.RequestsMock() as rsps:
+        mock_api_calls(rsps, "star", "2.8.10a")
         module_create = nf_core.modules.ModuleCreate(
             self.nfcore_modules, "star/index", "@author", "process_medium", False, False
         )

tests/test_modules.py

@@ -6,7 +6,7 @@
 import tempfile
 import unittest
 
-import requests_mock
+import responses
 
 import nf_core.create
 import nf_core.modules
@@ -35,8 +35,8 @@ def create_modules_repo_dummy(tmp_dir):
         fh.writelines(["repository_type: modules", "\n", "org_path: nf-core", "\n"])
 
     # mock biocontainers and anaconda response
-    with requests_mock.Mocker() as mock:
-        mock_api_calls(mock, "bpipe", "0.9.11--hdfd78af_0")
+    with responses.RequestsMock() as rsps:
+        mock_api_calls(rsps, "bpipe", "0.9.11--hdfd78af_0")
         # bpipe is a valid package on bioconda that is very unlikely to ever be added to nf-core/modules
         module_create = nf_core.modules.ModuleCreate(root_dir, "bpipe/test", "@author", "process_single", False, False)
         module_create.create()

tests/test_subworkflows.py

@@ -6,7 +6,7 @@
 import tempfile
 import unittest
 
-import requests_mock
+import responses
 
 import nf_core.create
 import nf_core.modules
@@ -30,7 +30,8 @@ def create_modules_repo_dummy(tmp_dir):
     with open(os.path.join(root_dir, ".nf-core.yml"), "w") as fh:
         fh.writelines(["repository_type: modules", "\n", "org_path: nf-core", "\n"])
 
-    with requests_mock.Mocker() as mock:
+    # FIXME This mock isn't used
+    with responses.RequestsMock() as rsps:
         subworkflow_create = nf_core.subworkflows.SubworkflowCreate(root_dir, "test_subworkflow", "@author", True)
         subworkflow_create.create()
 

tests/utils.py

@@ -8,6 +8,8 @@
 from contextlib import contextmanager
 from pathlib import Path
 
+import responses
+
 OLD_TRIMGALORE_SHA = "06348dffce2a732fc9e656bdc5c64c3e02d302cb"
 OLD_TRIMGALORE_BRANCH = "mimic-old-trimgalore"
 GITLAB_URL = "https://gitlab.com/nf-core/modules-test.git"
@@ -68,14 +70,13 @@ def set_wd(path: Path):
         os.chdir(start_wd)
 
 
-def mock_api_calls(mock, module, version):
+def mock_api_calls(rsps: responses.RequestsMock, module, version):
     """Mock biocontainers and anaconda api calls for module"""
     biocontainers_api_url = (
         f"https://api.biocontainers.pro/ga4gh/trs/v2/tools/{module}/versions/{module}-{version.split('--')[0]}"
     )
     anaconda_api_url = f"https://api.anaconda.org/package/bioconda/{module}"
     anaconda_mock = {
-        "status_code": 200,
         "latest_version": version.split("--")[0],
         "summary": "",
         "doc_url": "",
@@ -84,7 +85,6 @@ def mock_api_calls(mock, module, version):
         "license": "",
     }
     biocontainers_mock = {
-        "status_code": 200,
         "images": [
             {
                 "image_type": "Singularity",
@@ -98,5 +98,5 @@ def mock_api_calls(mock, module, version):
             },
         ],
     }
-    mock.register_uri("GET", anaconda_api_url, json=anaconda_mock)
-    mock.register_uri("GET", biocontainers_api_url, json=biocontainers_mock)
+    rsps.get(anaconda_api_url, json=anaconda_mock, status=200)
+    rsps.get(biocontainers_api_url, json=biocontainers_mock, status=200)