Merge pull request #7130 from nextcloud/backport/7127/stable31

[stable31] fix:allow foreign label deletion

Author: luka-nextcloud

lib/Service/CardService.php

@@ -652,9 +652,6 @@ public function removeLabel($cardId, $labelId) {
 			throw new StatusException('Operation not allowed. This card is archived.');
 		}
 		$label = $this->labelMapper->find($labelId);
-		if ($label->getBoardId() !== $this->cardMapper->findBoardId($card->getId())) {
-			throw new StatusException('Operation not allowed. Label does not exist.');
-		}
 		$this->cardMapper->removeLabel($cardId, $labelId);
 		$this->changeHelper->cardChanged($cardId);
 		$this->activityManager->triggerEvent(ActivityManager::DECK_OBJECT_CARD, $card, ActivityManager::SUBJECT_LABEL_UNASSING, ['label' => $label]);

tests/unit/Service/CardServiceTest.php

@@ -475,9 +475,6 @@ public function testRemoveLabel() {
 		$label->setBoardId(1);
 		$this->cardMapper->expects($this->once())->method('find')->willReturn($card);
 		$this->cardMapper->expects($this->once())->method('removeLabel');
-		$this->cardMapper->expects($this->once())
-			->method('findBoardId')
-			->willReturn(1);
 		$this->labelMapper->expects($this->once())
 			->method('find')
 			->willReturn($label);