Remove statement cacher (fix src-d#263)

Author: hlubek

generator/templates/model.tgo

@@ -118,11 +118,6 @@ func (s *{{.StoreName}}) DebugWith(logger kallax.LoggerFunc) *{{.StoreName}} {
         return &{{.StoreName}}{s.Store.DebugWith(logger)}
 }
 
-// DisableCacher turns off prepared statements, which can be useful in some scenarios.
-func (s *{{.StoreName}}) DisableCacher() *{{.StoreName}} {
-        return &{{.StoreName}}{s.Store.DisableCacher()}
-}
-
 {{if .HasNonInverses}}
 func (s *{{.StoreName}}) relationshipRecords(record *{{.Name}}) []modelSaveFunc {
         var result []modelSaveFunc

store.go

@@ -128,26 +128,20 @@ func (r *txRunner) QueryRow(query string, args ...interface{}) squirrel.RowScann
 type Store struct {
 	db        squirrel.DBProxyContext
 	runner    squirrel.DBProxyContext
-	useCacher bool
 	logger    LoggerFunc
 }
 
 // NewStore returns a new Store instance.
 func NewStore(db *sql.DB) *Store {
 	return (&Store{
 		db:        &dbRunner{db},
-		useCacher: true,
 	}).init()
 }
 
-// init initializes the store runner with debugging or caching, and returns itself for chainability
+// init initializes the store runner with debugging and returns itself for chainability
 func (s *Store) init() *Store {
 	s.runner = s.db
 
-	if s.useCacher {
-		s.runner = squirrel.NewStmtCacher(s.db)
-	}
-
 	if s.logger != nil {
 		s.runner = &proxyLogger{logger: s.logger, DBProxyContext: s.runner}
 	}
@@ -166,20 +160,10 @@ func (s *Store) Debug() *Store {
 func (s *Store) DebugWith(logger LoggerFunc) *Store {
 	return (&Store{
 		db:        s.db,
-		useCacher: s.useCacher,
 		logger:    logger,
 	}).init()
 }
 
-// DisableCacher returns a new store with prepared statements turned off, which can be useful in some scenarios.
-func (s *Store) DisableCacher() *Store {
-	return (&Store{
-		db:        s.db,
-		logger:    s.logger,
-		useCacher: false,
-	}).init()
-}
-
 // Insert insert the given record in the table, returns error if no-new
 // record is given. The record id is set if it's empty.
 func (s *Store) Insert(schema Schema, record Record) error {
@@ -494,7 +478,6 @@ func (s *Store) Transaction(callback func(*Store) error) error {
 	txStore := (&Store{
 		db:        &txRunner{tx},
 		logger:    s.logger,
-		useCacher: s.useCacher,
 	}).init()
 
 	if err := callback(txStore); err != nil {

store_test.go

@@ -257,7 +257,7 @@ func (s *StoreSuite) TestDebugWith() {
 		queries = append(queries, q)
 	}
 	s.store.DebugWith(logger).RawQuery("SELECT 1 + 1")
-	s.store.DisableCacher().DebugWith(logger).RawExec("UPDATE foo SET bar = 1")
+	s.store.DebugWith(logger).RawExec("UPDATE foo SET bar = 1")
 
 	s.Regexp("kallax: Query: \\(\\d+\\.\\d+.+\\) SELECT 1 \\+ 1", queries[0])
 	s.Regexp("kallax: Exec: \\(\\d+\\.\\d+.+\\) UPDATE foo SET bar = 1", queries[1])