From 144009546c6dbcce90d64f0e961f3bd4f8889113 Mon Sep 17 00:00:00 2001 From: MaxAake <61233757+MaxAake@users.noreply.github.com> Date: Fri, 23 May 2025 16:05:23 +0200 Subject: [PATCH 1/2] remove notification severity --- packages/core/src/notification.ts | 11 ----------- packages/neo4j-driver-deno/lib/core/notification.ts | 11 ----------- 2 files changed, 22 deletions(-) diff --git a/packages/core/src/notification.ts b/packages/core/src/notification.ts index f8a2829fd..c3f13669b 100644 --- a/packages/core/src/notification.ts +++ b/packages/core/src/notification.ts @@ -104,7 +104,6 @@ class Notification { code: string title: string description: string - severity: string position: NotificationPosition | {} severityLevel: NotificationSeverityLevel category: NotificationCategory @@ -135,16 +134,6 @@ class Notification { * @public */ this.description = notification.description - /** - * The raw severity - * - * Use {@link Notification#rawSeverityLevel} for the raw value or {@link Notification#severityLevel} for an enumerated value. - * - * @type {string} - * @public - * @deprecated This property will be removed in 6.0. - */ - this.severity = notification.severity /** * The position which the notification had occur. * diff --git a/packages/neo4j-driver-deno/lib/core/notification.ts b/packages/neo4j-driver-deno/lib/core/notification.ts index 39450086d..98cdaffe7 100644 --- a/packages/neo4j-driver-deno/lib/core/notification.ts +++ b/packages/neo4j-driver-deno/lib/core/notification.ts @@ -104,7 +104,6 @@ class Notification { code: string title: string description: string - severity: string position: NotificationPosition | {} severityLevel: NotificationSeverityLevel category: NotificationCategory @@ -135,16 +134,6 @@ class Notification { * @public */ this.description = notification.description - /** - * The raw severity - * - * Use {@link Notification#rawSeverityLevel} for the raw value or {@link Notification#severityLevel} for an enumerated value. - * - * @type {string} - * @public - * @deprecated This property will be removed in 6.0. - */ - this.severity = notification.severity /** * The position which the notification had occur. * From d245475071fba8100f3d0b8dee52c204c0b55ef7 Mon Sep 17 00:00:00 2001 From: MaxAake <61233757+MaxAake@users.noreply.github.com> Date: Mon, 26 May 2025 12:26:59 +0200 Subject: [PATCH 2/2] fix some tests for removed severity --- packages/neo4j-driver/test/rx/summary.test.js | 2 +- packages/neo4j-driver/test/summary.test.js | 2 +- packages/neo4j-driver/test/types/result-summary.test.ts | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/neo4j-driver/test/rx/summary.test.js b/packages/neo4j-driver/test/rx/summary.test.js index 423f03920..0c9b6d7a9 100644 --- a/packages/neo4j-driver/test/rx/summary.test.js +++ b/packages/neo4j-driver/test/rx/summary.test.js @@ -679,7 +679,7 @@ describe('#integration-rx summary', () => { ) expect(summary.notifications[0].title).toContain('label') expect(summary.notifications[0].description).toContain('label') - expect(summary.notifications[0].severity).toBe('WARNING') + expect(summary.notifications[0].rawSeverityLevel).toBe('WARNING') } /** diff --git a/packages/neo4j-driver/test/summary.test.js b/packages/neo4j-driver/test/summary.test.js index ff7714557..0d59b34fd 100644 --- a/packages/neo4j-driver/test/summary.test.js +++ b/packages/neo4j-driver/test/summary.test.js @@ -175,7 +175,7 @@ describe('#integration result summary', () => { expect(notification.code).toBeDefined() expect(notification.title).toBeDefined() expect(notification.description).toBeDefined() - expect(notification.severity).toBeDefined() + expect(notification.rawSeverityLevel).toBeDefined() expect(notification.position).toBeDefined() done() diff --git a/packages/neo4j-driver/test/types/result-summary.test.ts b/packages/neo4j-driver/test/types/result-summary.test.ts index a2ae2648a..589fa64af 100644 --- a/packages/neo4j-driver/test/types/result-summary.test.ts +++ b/packages/neo4j-driver/test/types/result-summary.test.ts @@ -86,7 +86,6 @@ const notification: Notification = notifications[0] const code: string = notification.code const title: string = notification.title const description: string = notification.description -const severity: string = notification.severity const position1: NotificationPosition | {} = notification.position const position2: NotificationPosition = notification.position as NotificationPosition