Standardise code and fix linter issues (#919)

Fix and apply the configured standard to the code base makes easier for the next changes go through the pipeline without have to mess up with tech debts. This also enables the lint stage be part of test routine, not only in the pre-commit hook (which could be by passed).

Author: bigmontz

package.json

@@ -49,6 +49,12 @@
     "lerna": "lerna",
     "prepare": "husky install",
     "lint-staged": "lint-staged",
+    "lint": "npm run lint::core && npm run lint::bolt-connection && npm run lint::bolt-connection && npm run lint::neo4j-driver-lite && npm run lint::neo4j-driver && npm run lint::testkit-backend",
+    "lint::core": "npm run ts-standard::core -- packages/core/src/ && npm run ts-standard::core -- packages/core/test/",
+    "lint::bolt-connection": "npm run ts-standard::bolt-connection -- packages/bolt-connection/types/ && npm run standard -- packages/bolt-connection/src/ && npm run standard -- packages/bolt-connection/test/",
+    "lint::neo4j-driver-lite": "npm run ts-standard::neo4j-driver-lite -- packages/neo4j-driver-lite/src/ && npm run ts-standard::neo4j-driver-lite -- packages/neo4j-driver-lite/test/",
+    "lint::neo4j-driver": "npm run ts-standard::neo4j-driver -- packages/neo4j-driver/types/ && npm run ts-standard::neo4j-driver -- packages/neo4j-driver/test/types/ && npm run standard -- packages/neo4j-driver/src/ && npm run standard -- packages/neo4j-driver/test/**/*.js",
+    "lint::testkit-backend": "npm run standard -- packages/testkit-backend/src/**/*.js",
     "ts-standard": "npm run ts-standard::core && npm run ts-standard::bolt-connection && npm run ts-standard::neo4j-driver-lite && npm run ts-standard::neo4j-driver",
     "ts-standard::core": "ts-standard --fix --project ./packages/core/tsconfig.json",
     "ts-standard::bolt-connection": "ts-standard --fix --project ./packages/bolt-connection/tsconfig.json",

packages/bolt-connection/src/bolt/bolt-protocol-util.js

@@ -17,6 +17,7 @@
  * limitations under the License.
  */
 import { newError } from 'neo4j-driver-core'
+// eslint-disable-next-line no-unused-vars
 import { ResultStreamObserver } from './stream-observers'
 
 /**
@@ -59,7 +60,7 @@ function assertDatabaseIsEmpty (database, onProtocolError = () => {}, observer)
 
 /**
  * Asserts that the passed-in impersonated user is empty
- * @param {string} impersonatedUser 
+ * @param {string} impersonatedUser
  * @param {function (err:Error)} onProtocolError Called when it does have impersonated user set
  * @param {any} observer
  */

packages/bolt-connection/src/bolt/bolt-protocol-v1.js

@@ -21,20 +21,23 @@ import {
   assertTxConfigIsEmpty,
   assertImpersonatedUserIsEmpty
 } from './bolt-protocol-util'
+// eslint-disable-next-line no-unused-vars
 import { Chunker } from '../channel'
 import { v1 } from '../packstream'
 import RequestMessage from './request-message'
 import {
   LoginObserver,
   ResetObserver,
   ResultStreamObserver,
+  // eslint-disable-next-line no-unused-vars
   StreamObserver
 } from './stream-observers'
 import { internal } from 'neo4j-driver-core'
 
 const {
   bookmarks: { Bookmarks },
   constants: { ACCESS_MODE_WRITE, BOLT_PROTOCOL_V1 },
+  // eslint-disable-next-line no-unused-vars
   logger: { Logger },
   txConfig: { TxConfig }
 } = internal

packages/bolt-connection/src/bolt/bolt-protocol-v3.js

@@ -28,6 +28,7 @@ import {
 import { internal } from 'neo4j-driver-core'
 
 const {
+  // eslint-disable-next-line no-unused-vars
   bookmarks: { Bookmarks },
   constants: { BOLT_PROTOCOL_V3 },
   txConfig: { TxConfig }

packages/bolt-connection/src/bolt/bolt-protocol-v4x0.js

@@ -27,6 +27,7 @@ import {
 import { internal } from 'neo4j-driver-core'
 
 const {
+  // eslint-disable-next-line no-unused-vars
   bookmarks: { Bookmarks },
   constants: { BOLT_PROTOCOL_V4_0, FETCH_ALL },
   txConfig: { TxConfig }

packages/bolt-connection/src/bolt/bolt-protocol-v4x4.js

@@ -24,11 +24,11 @@ import { RouteObserver, ResultStreamObserver } from './stream-observers'
 
 const {
   constants: { BOLT_PROTOCOL_V4_4, FETCH_ALL },
-  bookmarks: { Bookmarks },
+  bookmarks: { Bookmarks }
 } = internal
 
 export default class BoltProtocol extends BoltProtocolV43 {
-  get version() {
+  get version () {
     return BOLT_PROTOCOL_V4_4
   }
 
@@ -153,5 +153,4 @@ export default class BoltProtocol extends BoltProtocolV43 {
 
     return observer
   }
-
 }

packages/bolt-connection/src/bolt/bolt-protocol-v5x0.js

@@ -22,11 +22,11 @@ import { v5 } from '../packstream'
 import { internal } from 'neo4j-driver-core'
 
 const {
-  constants: { BOLT_PROTOCOL_V5_0 },
+  constants: { BOLT_PROTOCOL_V5_0 }
 } = internal
 
 export default class BoltProtocol extends BoltProtocolV44 {
-  get version() {
+  get version () {
     return BOLT_PROTOCOL_V5_0
   }
 

packages/bolt-connection/src/bolt/create.js

@@ -27,6 +27,7 @@ import BoltProtocolV4x2 from './bolt-protocol-v4x2'
 import BoltProtocolV4x3 from './bolt-protocol-v4x3'
 import BoltProtocolV4x4 from './bolt-protocol-v4x4'
 import BoltProtocolV5x0 from './bolt-protocol-v5x0'
+// eslint-disable-next-line no-unused-vars
 import { Chunker, Dechunker } from '../channel'
 import ResponseHandler from './response-handler'
 

packages/bolt-connection/src/bolt/request-message.js

@@ -250,14 +250,14 @@ export default class RequestMessage {
    * @param {string} databaseContext.impersonatedUser The name of the user to impersonation when getting the routing table.
    * @return {RequestMessage} the ROUTE message.
    */
-   static routeV4x4 (routingContext = {}, bookmarks = [], databaseContext = {}) {
+  static routeV4x4 (routingContext = {}, bookmarks = [], databaseContext = {}) {
     const dbContext = {}
 
-    if ( databaseContext.databaseName ) {
+    if (databaseContext.databaseName) {
       dbContext.db = databaseContext.databaseName
     }
 
-    if ( databaseContext.impersonatedUser ) {
+    if (databaseContext.impersonatedUser) {
       dbContext.imp_user = databaseContext.impersonatedUser
     }
 

packages/bolt-connection/src/bolt/response-handler.js

@@ -193,5 +193,4 @@ export default class ResponseHandler {
   _resetFailure () {
     this._currentFailure = null
   }
-
 }