Skip to content

Commit b65dbc1

Browse files
committed
Rename GqlNotification.inputPosition to GqlNotification.position
1 parent cae0c28 commit b65dbc1

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

driver/src/main/java/org/neo4j/driver/internal/summary/InternalGqlNotification.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public InternalGqlNotification(
4949
}
5050

5151
@Override
52-
public Optional<InputPosition> inputPosition() {
52+
public Optional<InputPosition> position() {
5353
return Optional.ofNullable(position);
5454
}
5555

driver/src/main/java/org/neo4j/driver/summary/GqlNotification.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public sealed interface GqlNotification extends GqlStatusObject permits Internal
3737
*
3838
* @return an {@link Optional} of the {@link InputPosition} if available or an empty {@link Optional} otherwise
3939
*/
40-
Optional<InputPosition> inputPosition();
40+
Optional<InputPosition> position();
4141

4242
/**
4343
* Returns the severity level of the notification derived from the diagnostic record.

driver/src/test/java/org/neo4j/driver/internal/util/MetadataExtractorTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ void shouldBuildResultSummaryWithNotifications() {
274274
assertEquals("DEPRECATION", firstGqlStatusObject.rawClassification().get());
275275
assertEquals(
276276
new InternalInputPosition(42, 4242, 424242),
277-
firstGqlStatusObject.inputPosition().get());
277+
firstGqlStatusObject.position().get());
278278
assertEquals(
279279
Map.of(
280280
"OPERATION",
@@ -305,7 +305,7 @@ void shouldBuildResultSummaryWithNotifications() {
305305
assertEquals("INFO", secondGqlStatusObject.rawSeverityLevel().get());
306306
assertFalse(secondGqlStatusObject.classification().isPresent());
307307
assertFalse(secondGqlStatusObject.rawClassification().isPresent());
308-
assertTrue(secondGqlStatusObject.inputPosition().isEmpty());
308+
assertTrue(secondGqlStatusObject.position().isEmpty());
309309
assertEquals(
310310
Map.of(
311311
"OPERATION", Values.value(""),
@@ -373,7 +373,7 @@ void shouldBuildResultSummaryWithGqlStatusObjects() {
373373
assertEquals("SECURITY", firstGqlStatusObject.rawClassification().get());
374374
assertEquals(
375375
new InternalInputPosition(42, 4242, 424242),
376-
firstGqlStatusObject.inputPosition().get());
376+
firstGqlStatusObject.position().get());
377377
assertEquals(
378378
Map.of(
379379
"OPERATION",

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/SummaryUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ public static Summary.SummaryBody toSummaryBody(org.neo4j.driver.summary.ResultS
8484
.statusDescription(gqlStatusObject.statusDescription())
8585
.diagnosticRecord(gqlStatusObject.diagnosticRecord());
8686
if (gqlStatusObject instanceof GqlNotification notification) {
87-
builder = builder.position(toInputPosition(
88-
notification.inputPosition().orElse(null)))
87+
builder = builder.position(
88+
toInputPosition(notification.position().orElse(null)))
8989
.severity(notification
9090
.severityLevel()
9191
.map(InternalNotificationSeverity.class::cast)

0 commit comments

Comments
 (0)