Skip to content

Commit 81449d2

Browse files
minor cleanups (#718)
1 parent 0d60804 commit 81449d2

File tree

6 files changed

+9
-10
lines changed

6 files changed

+9
-10
lines changed

Neo4j.Driver/Neo4j.Driver/Auth/AuthTokens.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,7 @@ public static IAuthToken Custom(
176176
/// an authentication token that can be used to connect to Neo4j.
177177
/// </summary>
178178
/// <remarks>
179-
/// <see
180-
/// cref="GraphDatabase.Driver(string, IAuthToken, System.Action{Neo4j.Driver.ConfigBuilder}(Neo4j.Driver.ConfigBuilder))"/>
179+
/// <see cref="GraphDatabase.Driver(string, IAuthToken, System.Action{Neo4j.Driver.ConfigBuilder})"/>
181180
/// </remarks>
182181
/// <param name="token">Base64 encoded token</param>
183182
/// <returns>An authentication token that can be used to connect to Neo4j.</returns>

Neo4j.Driver/Neo4j.Driver/Internal/Auth/AuthToken.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public override bool Equals(object obj)
5050
return obj is AuthToken a && Equals(a);
5151
}
5252

53-
protected bool Equals(AuthToken other)
53+
private bool Equals(AuthToken other)
5454
{
5555
if (ReferenceEquals(this, other))
5656
{

Neo4j.Driver/Neo4j.Driver/Internal/ExecuteQuery/ExecutableQuery.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ internal class ExecutableQuery<TIn, TOut> : IExecutableQuery<TIn, TOut>, IQueryR
2828
private readonly List<Func<TOut, bool>> _filters = new();
2929
private readonly Func<TIn, TOut> _mapper;
3030
private readonly IQueryRowSource<TIn> _rowSource;
31-
private Action<TOut, TIn, TOut> _accumulateValue;
32-
private Func<TOut> _reduceSeed;
3331

3432
internal ExecutableQuery(
3533
IQueryRowSource<TIn> rowSource,

Neo4j.Driver/Neo4j.Driver/Internal/ExecuteQuery/ReducedExecutableQuery.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ namespace Neo4j.Driver;
2424
internal class ReducedExecutableQuery<TSource, TAccumulate, TResult> : IReducedExecutableQuery<TResult>
2525
{
2626
private readonly Func<TAccumulate, TSource, TAccumulate> _accumulate;
27-
private readonly Query _query;
28-
private readonly QueryConfig _queryConfig;
2927
private readonly IQueryRowSource<TSource> _rowSource;
3028
private readonly Func<TAccumulate> _seed;
3129
private readonly Func<TAccumulate, TResult> _selectResult;

Neo4j.Driver/Neo4j.Driver/Internal/Result/SummaryBuilder.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,13 +320,12 @@ public Notification(
320320
Title = title;
321321
Description = description;
322322
Position = position;
323-
Severity = severity;
324323
RawSeverityLevel = severity;
325324
RawCategory = rawCategory;
326325
}
327326

328327
public string RawSeverityLevel { get; }
329-
public NotificationSeverity SeverityLevel => ParseSeverity(Severity);
328+
public NotificationSeverity SeverityLevel => ParseSeverity(RawSeverityLevel);
330329
public string RawCategory { get; }
331330
public NotificationCategory Category => ParseCategory(RawCategory);
332331
public string Code { get; }
@@ -335,7 +334,7 @@ public Notification(
335334
public IInputPosition Position { get; }
336335

337336
[Obsolete("Deprecated, Replaced by RawSeverityLevel. Will be removed in 6.0")]
338-
public string Severity { get; }
337+
public string Severity => RawSeverityLevel;
339338

340339
private NotificationCategory ParseCategory(string category)
341340
{

Neo4j.Driver/Neo4j.Driver/Neo4jException.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -371,6 +371,10 @@ public TokenExpiredException(string message) : base(ErrorCode, message)
371371
{
372372
}
373373

374+
/// <summary>
375+
/// Whether or not the exception is retriable. If the exception is retriable, the driver will try to
376+
/// re-run the operation that caused the exception.
377+
/// </summary>
374378
public override bool IsRetriable => Retriable;
375379

376380
internal static bool IsTokenExpiredError(string code)
@@ -587,6 +591,7 @@ public TransactionClosedException(string message) : base(message)
587591
[DataContract]
588592
public class UnsupportedFeatureException : ClientException
589593
{
594+
/// <inheritdoc />
590595
public override bool IsRetriable => false;
591596

592597
/// <summary>

0 commit comments

Comments
 (0)