WV-2814: Turn on required PropType validation for ESLint. Fixed files to pass ESLint (#6291)

* Set 'error' to react/prop-types and react/no-unused-prop-types

* ESLint props validation fixes Part 1

* Fixes to files with missing prop-type validation

* Removed old comments from web/.eslintrc

Author: jwhurley1

web/.eslintrc

@@ -160,8 +160,8 @@
         "react/no-unknown-property": "error",
         "react/jsx-no-useless-fragment": "error",
         "react/no-unstable-nested-components": "error",
-        "react/prop-types": "warn",                        // 58 errors across 22 files
-        "react/no-unused-prop-types": "warn",              // 9 errors across 9 files
+        "react/prop-types": "error",
+        "react/no-unused-prop-types": "error",
         "default-param-last": "warn",                      // 42 errors across 34 files
         "prefer-regex-literals": "error",
         "no-promise-executor-return": "error"

web/js/components/animation-widget/gif-post-creation.js

@@ -141,6 +141,7 @@ export default class GifResults extends Component {
 
 GifResults.propTypes = {
   boundaries: PropTypes.object,
+  closeBtn: PropTypes.object,
   endDate: PropTypes.string,
   gifObject: PropTypes.object,
   increment: PropTypes.string,

web/js/components/date-selector/date-input-column.js

@@ -345,6 +345,7 @@ DateInputColumn.propTypes = {
   date: PropTypes.object,
   fontSize: PropTypes.number,
   idSuffix: PropTypes.string,
+  isKioskModeActive: PropTypes.bool,
   isValid: PropTypes.bool,
   isStartDate: PropTypes.bool,
   isEndDate: PropTypes.bool,

web/js/components/layer/info/date-ranges.js

@@ -1,5 +1,6 @@
 import React, { useState } from 'react';
 import { ListGroup, ListGroupItem, Spinner } from 'reactstrap';
+import PropTypes from 'prop-types';
 import Scrollbar from '../../util/scrollbar';
 import { coverageDateFormatter } from '../../../modules/date/util';
 
@@ -100,3 +101,7 @@ export default function DateRanges ({ layer }) {
     </>
   );
 }
+
+DateRanges.propTypes = {
+  layer: PropTypes.object,
+};

web/js/components/layer/product-picker/browse/category-grid.js

@@ -89,7 +89,6 @@ CategoryGrid.propTypes = {
   showMeasurements: PropTypes.func,
   hasMeasurementSource: PropTypes.func,
   measurementConfig: PropTypes.object,
-  width: PropTypes.number,
 };
 
 export default connect(

web/js/components/layer/settings/band-selection/band-selection-parent-info-menu.js

@@ -1,6 +1,7 @@
 import React from 'react';
 import { useDispatch } from 'react-redux';
 import { Button } from 'reactstrap';
+import PropTypes from 'prop-types';
 import BandSelectionMenu from './band-selection-menu';
 import { toggleCustomContent } from '../../../../modules/modal/actions';
 
@@ -96,3 +97,7 @@ export default function BandSelectionParentInfoMenu({ layer }) {
     </div>
   );
 }
+
+BandSelectionParentInfoMenu.propTypes = {
+  layer: PropTypes.object,
+};

web/js/components/layer/settings/band-selection/menu-components/band-dropdown.js

@@ -1,3 +1,4 @@
+import PropTypes from 'prop-types';
 import React, { useState } from 'react';
 import {
   Dropdown,
@@ -42,3 +43,11 @@ export default function BandsDropdown(props) {
     </Dropdown>
   );
 }
+
+BandsDropdown.propTypes = {
+  channel: PropTypes.string,
+  bandSelection: PropTypes.object,
+  setBandSelection: PropTypes.func,
+  layer: PropTypes.object,
+  setSelectedPreset: PropTypes.func,
+};

web/js/components/layer/settings/band-selection/menu-components/preset-options.js

@@ -1,4 +1,5 @@
 import React from 'react';
+import PropTypes from 'prop-types';
 import {
   Card, CardImg, CardBody, CardTitle, CardText,
 } from 'reactstrap';
@@ -345,3 +346,10 @@ export default function PresetOptions(props) {
     </div>
   );
 }
+
+PresetOptions.propTypes = {
+  setBandSelection: PropTypes.func,
+  selectedPreset: PropTypes.object,
+  setSelectedPreset: PropTypes.func,
+  presetOptions: PropTypes.string,
+};

web/js/components/layer/settings/imagery-search.js

@@ -3,6 +3,7 @@ import { useSelector, useDispatch } from 'react-redux';
 import {
   Spinner,
 } from 'reactstrap';
+import PropTypes from 'prop-types';
 import { selectDate as selectDateAction } from '../../../modules/date/actions';
 
 const dateOptions = {
@@ -170,3 +171,7 @@ export default function ImagerySearch({ layer }) {
     </div>
   );
 }
+
+ImagerySearch.propTypes = {
+  layer: PropTypes.object,
+};

web/js/components/layer/settings/layer-settings.js

@@ -441,7 +441,6 @@ LayerSettings.defaultProps = {
 };
 LayerSettings.propTypes = {
   clearCustomPalette: PropTypes.func,
-  clearStyle: PropTypes.func,
   customPalettesIsActive: PropTypes.bool,
   getCustomPalette: PropTypes.func,
   getDefaultLegend: PropTypes.func,
@@ -452,19 +451,16 @@ LayerSettings.propTypes = {
   globalTemperatureUnit: PropTypes.string,
   groupName: PropTypes.string,
   layer: PropTypes.object,
-  onCustomizeBandClick: PropTypes.func,
   palettedAllowed: PropTypes.bool,
   paletteOrder: PropTypes.array,
   palettesTranslate: PropTypes.func,
   resetGranuleLayerDates: PropTypes.func,
   screenHeight: PropTypes.number,
   setCustomPalette: PropTypes.func,
   setOpacity: PropTypes.func,
-  setStyle: PropTypes.func,
   setThresholdRange: PropTypes.func,
   toggleClassification: PropTypes.func,
   updateGranuleLayerOptions: PropTypes.func,
   toggleAllClassifications: PropTypes.func,
-  vectorStyles: PropTypes.object,
   zot: PropTypes.object,
 };