Skip to content

Commit fda5944

Browse files
authored
fix: restore Python 3.11 support and stop ty failing CI on warnings (#898)
Two independent root causes had kept main red since 2026-07-05. Renovate bumped numpy to >=2.5.1. numpy 2.5.0 dropped Python 3.11 wheels entirely (2.5.1 declares requires_python >=3.12; 2.4.6 declares >=3.11), which contradicts this project's own requires-python >=3.11 and its 3.11-3.14 CI matrix, so uv could not resolve on any runner. Reverting the pin restores what commit 4ad79c3 had deliberately established before Renovate undid it, and a renovate.json packageRule now prevents the same regression. The same Renovate commit bumped ty from 0.0.51 to 0.0.57, which exits non-zero on warning-only output. pyproject.toml deliberately downgrades seven rules to warn, with comments explaining why (llama_cpp is an optional dependency; onnxruntime ships incomplete stubs). Passing ty's own --exit-zero-on-warning restores that intent. Error-level diagnostics still fail the build.
1 parent 59b22ed commit fda5944

6 files changed

Lines changed: 44 additions & 105 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969

7070
- name: Run type check
7171
if: matrix.python-version == '3.13' && matrix.os == 'ubuntu-latest'
72-
run: uv run ty check
72+
run: uv run ty check --exit-zero-on-warning
7373

7474
- name: Run tests with coverage
7575
run: uv run pytest -m "not integration" --tb=short --cov=qwen3_embed

.mise.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ description = "Run all quality checks (ruff + ty)"
2626
run = [
2727
"uv run ruff check .",
2828
"uv run ruff format --check .",
29-
"uv run ty check",
29+
"uv run ty check --exit-zero-on-warning",
3030
]
3131

3232
[tasks.test]

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ repos:
3939
hooks:
4040
- id: ty
4141
name: ty type check
42-
entry: mise exec -- uv run ty check
42+
entry: mise exec -- uv run ty check --exit-zero-on-warning
4343
language: system
4444
types: [python]
4545
pass_filenames: false

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ classifiers = [
2020
]
2121

2222
dependencies = [
23-
"numpy>=2.5.1,<2.6",
23+
"numpy>=2.4.6,<2.5",
2424
"onnxruntime>1.20.0; python_version >= '3.11'",
2525
"tqdm>=4.68.3",
2626
"requests>=2.34.2",

renovate.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,13 @@
7777
],
7878
"enabled": false
7979
},
80+
{
81+
"description": "Pin numpy <2.5 -- 2.5.0 dropped Python 3.11 wheels, breaking requires-python >=3.11",
82+
"matchPackageNames": [
83+
"numpy"
84+
],
85+
"allowedVersions": "<2.5.0"
86+
},
8087
{
8188
"description": "Pin Node.js runtime to 24.x",
8289
"matchPackageNames": [

0 commit comments

Comments
 (0)