fix: testing] Test OSError/ValueError in HF download (#265)

* 🧪 [testing] Test OSError/ValueError in HF download

Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>

* 🧪 [testing] Fix ruff format check

Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: n24q02m

tests/test_model_management.py

@@ -567,6 +567,70 @@ def test_online_download_failure_raises_value_error(
                 extra_patterns=["model.onnx"],
             )
 
+    @patch("qwen3_embed.common.model_management.list_repo_tree")
+    @patch("qwen3_embed.common.model_management.model_info")
+    @patch("qwen3_embed.common.model_management.snapshot_download")
+    def test_metadata_save_mkdir_oserror_swallowed(
+        self, mock_snap, mock_info, mock_tree, tmp_path
+    ):
+        """OSError while creating metadata directory is logged but does not raise."""
+        snapshot_dir = tmp_path / "models--org--repo"
+        # We DO NOT create snapshot_dir so that .exists() is False
+
+        repo_files = [make_repo_file("model.onnx", size=500, oid="aaa")]
+        mock_info.return_value = Mock(sha="rev123")
+        mock_tree.return_value = repo_files
+        mock_snap.return_value = str(snapshot_dir)
+
+        # Patch Path.mkdir to raise OSError
+        original_mkdir = Path.mkdir
+
+        def patched_mkdir(self, *args, **kwargs):
+            if "models--org--repo" in str(self):
+                raise OSError("permission denied")
+            return original_mkdir(self, *args, **kwargs)
+
+        with patch.object(Path, "mkdir", patched_mkdir):
+            # Should not raise
+            result = ModelManagement.download_files_from_huggingface(
+                hf_source_repo="org/repo",
+                cache_dir=str(tmp_path),
+                extra_patterns=["model.onnx"],
+            )
+        assert result == str(snapshot_dir)
+
+    @patch("qwen3_embed.common.model_management.list_repo_tree")
+    @patch("qwen3_embed.common.model_management.model_info")
+    @patch("qwen3_embed.common.model_management.snapshot_download")
+    def test_metadata_save_mkdir_valueerror_swallowed(
+        self, mock_snap, mock_info, mock_tree, tmp_path
+    ):
+        """ValueError while creating metadata directory is logged but does not raise."""
+        snapshot_dir = tmp_path / "models--org--repo"
+        # We DO NOT create snapshot_dir so that .exists() is False
+
+        repo_files = [make_repo_file("model.onnx", size=500, oid="aaa")]
+        mock_info.return_value = Mock(sha="rev123")
+        mock_tree.return_value = repo_files
+        mock_snap.return_value = str(snapshot_dir)
+
+        # Patch Path.mkdir to raise ValueError
+        original_mkdir = Path.mkdir
+
+        def patched_mkdir(self, *args, **kwargs):
+            if "models--org--repo" in str(self):
+                raise ValueError("invalid path")
+            return original_mkdir(self, *args, **kwargs)
+
+        with patch.object(Path, "mkdir", patched_mkdir):
+            # Should not raise
+            result = ModelManagement.download_files_from_huggingface(
+                hf_source_repo="org/repo",
+                cache_dir=str(tmp_path),
+                extra_patterns=["model.onnx"],
+            )
+        assert result == str(snapshot_dir)
+
     @patch("qwen3_embed.common.model_management.list_repo_tree")
     @patch("qwen3_embed.common.model_management.model_info")
     @patch("qwen3_embed.common.model_management.snapshot_download")