fix: simplify _download_from_gcs parameter list via dataclass

Refactored `_download_from_gcs` to use the `model` description object as a configuration object instead of passing individual fields. This reduces the parameter count and improves maintainability by leveraging existing data structures.

Changes:
- Updated `_download_from_gcs` signature to `(cls, model: T, cache_dir: str, **kwargs: Any)`.
- Updated call site in `download_model`.
- Updated corresponding unit tests in `tests/test_model_management.py`.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: n24q02m

qwen3_embed/common/model_management.py

@@ -601,18 +601,18 @@ def _download_from_hf(
     @classmethod
     def _download_from_gcs(
         cls,
-        model_name: str,
-        url_source: str | None,
+        model: T,
         cache_dir: str,
-        deprecated_tar_struct: bool,
-        local_files_only: bool,
+        **kwargs: Any,
     ) -> Path | None:
+        url_source = model.sources.url
+        local_files_only = kwargs.get("local_files_only", False)
         try:
             return cls.retrieve_model_gcs(
-                model_name,
+                model.model,
                 str(url_source),
                 str(cache_dir),
-                deprecated_tar_struct=deprecated_tar_struct,
+                deprecated_tar_struct=model.sources.deprecated_tar_struct,
                 local_files_only=local_files_only,
             )
         except (OSError, ValueError, requests.RequestException, tarfile.TarError):
@@ -684,11 +684,9 @@ def download_model(cls, model: T, cache_dir: str, retries: int = 3, **kwargs: An
 
             if url_source or local_files_only:
                 gcs_path = cls._download_from_gcs(
-                    model_name=model.model,
-                    url_source=url_source,
+                    model=model,
                     cache_dir=cache_dir,
-                    deprecated_tar_struct=model.sources.deprecated_tar_struct,
-                    local_files_only=local_files_only,
+                    **kwargs,
                 )
                 if gcs_path:
                     return gcs_path

tests/test_model_management.py

@@ -1234,11 +1234,10 @@ def test_download_from_gcs_returns_none_on_exception(self, mock_logger, tmp_path
         with patch.object(
             ModelManagement, "retrieve_model_gcs", side_effect=ValueError("GCS Error")
         ):
+            model = make_model_description(url="http://example.com/model.tar.gz")
             result = ModelManagement._download_from_gcs(
-                model_name="test/model",
-                url_source="http://example.com/model.tar.gz",
+                model=model,
                 cache_dir=str(tmp_path),
-                deprecated_tar_struct=False,
                 local_files_only=False,
             )
 
@@ -1253,11 +1252,10 @@ def test_download_from_gcs_no_logger_on_local_files_only(self, mock_logger, tmp_
         with patch.object(
             ModelManagement, "retrieve_model_gcs", side_effect=ValueError("GCS Error")
         ):
+            model = make_model_description(url="http://example.com/model.tar.gz")
             result = ModelManagement._download_from_gcs(
-                model_name="test/model",
-                url_source="http://example.com/model.tar.gz",
+                model=model,
                 cache_dir=str(tmp_path),
-                deprecated_tar_struct=False,
                 local_files_only=True,
             )