feature, test: completed the selections by time interval

Author: n0rfas

.github/workflows/code-check-dev.yml

@@ -44,4 +44,4 @@ jobs:
       - run: pipx install "poetry~=2.0.0"
       - run: poetry install --with dev
       - run: poetry run ruff check --select I .
-      - run: poetry run pytest --cov=git_analytics --cov-report=term-missing --cov-fail-under=30
+      - run: poetry run pytest --cov=git_analytics --cov-report=term-missing --cov-fail-under=40

README.md

@@ -49,7 +49,7 @@ poetry run git-analytics
 
 ```bash
 poetry run pytest
-poetry run pytest --cov=git_analytics --cov-report=term-missing --cov-fail-under=30
+poetry run pytest --cov=git_analytics --cov-report=term-missing --cov-fail-under=40
 ```
 
 ### Type Checking

git_analytics/engine.py

@@ -20,13 +20,19 @@ def run(
         stop_date: Optional[date] = None,
     ) -> Dict[str, AnalyticsResult]:
         analyzers = self._analyzers_factory()
+
+        if start_date and stop_date and start_date > stop_date:
+            start_date, stop_date = stop_date, start_date
+
         for commit in self._source.iter_commits():
-            if start_date and stop_date:
-                commit_day = commit.committed_datetime.astimezone(timezone.utc).date()
-                if commit_day < start_date:
-                    break
-                if stop_date > commit_day:
-                    continue
+            commit_day = commit.committed_datetime.astimezone(timezone.utc).date()
+
+            if stop_date and commit_day > stop_date:
+                continue
+
+            if start_date and commit_day < start_date:
+                break
+
             for analyzer in analyzers:
                 analyzer.process(commit)
 

git_analytics/static/index.html

@@ -119,7 +119,7 @@ <h1 class="h3 mb-4">Statistics by time</h1>
                 <div class="col-md-12">
                     <div class="card h-100 w-100">
                         <div class="card-header">
-                            Commit by day of week
+                            Commit by day of month
                         </div>
                         <div class="card-body">
                             <canvas id="chartMonth"></canvas>
@@ -191,7 +191,7 @@ <h1 class="h3 mb-4">Other statistics</h1>
     <script src="js/git-analytics.js"></script>
 
     <!-- Loading Modal -->
-    <div class="modal fade" id="loadingModal" tabindex="-1" aria-hidden="true" data-bs-backdrop="static" data-bs-keyboard="false">
+    <div class="modal" id="loadingModal" tabindex="-1" aria-hidden="true" data-bs-backdrop="static" data-bs-keyboard="false">
         <div class="modal-dialog modal-dialog-centered">
             <div class="modal-content text-center">
                 <div class="modal-body">

pyproject.toml

@@ -20,6 +20,7 @@ pytest = "^7.4"
 pytest-cov = "^4.1"
 mypy = "^1.4"
 ruff = "^0.12"
+freezegun= "^1.5"
 
 [tool.poetry.scripts]
 git-analytics = 'git_analytics.main:run'

tests/fake_analyzer.py

@@ -0,0 +1,23 @@
+from dataclasses import dataclass, field
+from typing import List
+
+from git_analytics.entities import AnalyticsCommit, AnalyticsResult
+from git_analytics.interfaces import CommitAnalyzer
+
+
+@dataclass
+class Result(AnalyticsResult):
+    list_sha: List[str] = field(default_factory=list)
+
+
+class FakeAnalyzer(CommitAnalyzer):
+    name = "fake_analyzer"
+
+    def __init__(self) -> None:
+        self._result = Result()
+
+    def process(self, commit: AnalyticsCommit) -> None:
+        self._result.list_sha.append(commit.sha)
+
+    def result(self) -> Result:
+        return self._result