chore: validate and test CIDv0 invariants

Adds tests for
- base other than 'base32btc' for CIDv0
- codec other than 'dag-pb' for CIDv0

License: MIT
Signed-off-by: Oli Evans <[email protected]>

Author: olizilla

src/cid-util.js

@@ -24,6 +24,15 @@ var CIDUtil = {
       return 'codec must be string'
     }
 
+    if (other.version === 0) {
+      if (other.codec !== 'dag-pb') {
+        return `codec must be 'dag-pb' for CIDv0`
+      }
+      if (other.multibaseName !== 'base58btc') {
+        return `multibaseName must be 'base58btc' for CIDv0`
+      }
+    }
+
     if (!Buffer.isBuffer(other.multihash)) {
       return 'multihash must be a Buffer'
     }

test/index.spec.js

@@ -66,7 +66,19 @@ describe('CID', () => {
       ).to.throw()
     })
 
-    it('throws on trying to base encode CIDv0 in other base than base58 ', () => {
+    it('throws on trying to create a CIDv0 with a codec other than dag-pb', () => {
+      expect(
+        () => new CID(0, 'dag-cbor', hash)
+      ).to.throw(`codec must be 'dag-pb' for CIDv0`)
+    })
+
+    it('throws on trying to create a CIDv0 with a base other than base58btc', () => {
+      expect(
+        () => new CID(0, 'dag-pb', hash, 'base32')
+      ).to.throw(`multibaseName must be 'base58btc' for CIDv0`)
+    })
+
+    it('throws on trying to base encode CIDv0 in other base than base58btc', () => {
       const mhStr = 'QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n'
       const cid = new CID(mhStr)
       expect(() => cid.toBaseEncodedString('base16')).to.throw()