Skip to content

Commit a8057b9

Browse files
mudlermudler
authored
fix(cuda): be consistent with image tag naming (#5916)
Signed-off-by: Ettore Di Giacinto <[email protected]>
1 parent fd5c1d9 commit a8057b9

File tree

7 files changed

+12
-12
lines changed

7 files changed

+12
-12
lines changed

‎.github/workflows/image-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
cuda-minor-version: "0"
4040
platforms: 'linux/amd64'
4141
tag-latest: 'false'
42-
tag-suffix: '-gpu-nvidia-cuda12'
42+
tag-suffix: '-gpu-nvidia-cuda-12'
4343
runs-on: 'ubuntu-latest'
4444
base-image: "ubuntu:22.04"
4545
makeflags: "--jobs=3 --output-sync=target"

‎.github/workflows/image.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ jobs:
8383
cuda-minor-version: "7"
8484
platforms: 'linux/amd64'
8585
tag-latest: 'auto'
86-
tag-suffix: '-gpu-nvidia-cuda11'
86+
tag-suffix: '-gpu-nvidia-cuda-11'
8787
runs-on: 'ubuntu-latest'
8888
base-image: "ubuntu:22.04"
8989
makeflags: "--jobs=4 --output-sync=target"
@@ -94,7 +94,7 @@ jobs:
9494
cuda-minor-version: "0"
9595
platforms: 'linux/amd64'
9696
tag-latest: 'auto'
97-
tag-suffix: '-gpu-nvidia-cuda12'
97+
tag-suffix: '-gpu-nvidia-cuda-12'
9898
runs-on: 'ubuntu-latest'
9999
base-image: "ubuntu:22.04"
100100
skip-drivers: 'false'

‎Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ docker-cuda11:
322322
--build-arg GO_TAGS="$(GO_TAGS)" \
323323
--build-arg MAKEFLAGS="$(DOCKER_MAKEFLAGS)" \
324324
--build-arg BUILD_TYPE=$(BUILD_TYPE) \
325-
-t $(DOCKER_IMAGE)-cuda11 .
325+
-t $(DOCKER_IMAGE)-cuda-11 .
326326

327327
docker-aio:
328328
@echo "Building AIO image with base $(BASE_IMAGE) as $(DOCKER_AIO_IMAGE)"

‎backend/python/common/libbackend.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ function ensureVenv() {
111111
# - requirements-${BUILD_TYPE}.txt
112112
# - requirements-${BUILD_PROFILE}.txt
113113
#
114-
# BUILD_PROFILE is a pore specific version of BUILD_TYPE, ex: cuda11 or cuda12
114+
# BUILD_PROFILE is a pore specific version of BUILD_TYPE, ex: cuda-11 or cuda-12
115115
# it can also include some options that we do not have BUILD_TYPES for, ex: intel
116116
#
117117
# NOTE: for BUILD_PROFILE==intel, this function does NOT automatically use the Intel python package index.

‎docs/content/docs/features/GPU-acceleration.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ To use CUDA, use the images with the `cublas` tag, for example.
8181

8282
The image list is on [quay](https://quay.io/repository/go-skynet/local-ai?tab=tags):
8383

84-
- CUDA `11` tags: `master-gpu-nvidia-cuda11`, `v1.40.0-gpu-nvidia-cuda11`, ...
85-
- CUDA `12` tags: `master-gpu-nvidia-cuda12`, `v1.40.0-gpu-nvidia-cuda12`, ...
84+
- CUDA `11` tags: `master-gpu-nvidia-cuda-11`, `v1.40.0-gpu-nvidia-cuda-11`, ...
85+
- CUDA `12` tags: `master-gpu-nvidia-cuda-12`, `v1.40.0-gpu-nvidia-cuda-12`, ...
8686

8787
In addition to the commands to run LocalAI normally, you need to specify `--gpus all` to docker, for example:
8888

‎docs/content/docs/getting-started/container-images.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,19 +163,19 @@ Standard container images do not have pre-installed models.
163163

164164
| Description | Quay | Docker Hub |
165165
| --- | --- |-------------------------------------------------------------|
166-
| Latest images from the branch (development) | `quay.io/go-skynet/local-ai:master-gpu-nvidia-cuda11` | `localai/localai:master-gpu-nvidia-cuda11` |
166+
| Latest images from the branch (development) | `quay.io/go-skynet/local-ai:master-gpu-nvidia-cuda-11` | `localai/localai:master-gpu-nvidia-cuda-11` |
167167
| Latest tag | `quay.io/go-skynet/local-ai:latest-gpu-nvidia-cuda-11` | `localai/localai:latest-gpu-nvidia-cuda-11` |
168-
| Versioned image | `quay.io/go-skynet/local-ai:{{< version >}}-gpu-nvidia-cuda11` | `localai/localai:{{< version >}}-gpu-nvidia-cuda11` |
168+
| Versioned image | `quay.io/go-skynet/local-ai:{{< version >}}-gpu-nvidia-cuda-11` | `localai/localai:{{< version >}}-gpu-nvidia-cuda-11` |
169169

170170
{{% /tab %}}
171171

172172
{{% tab tabName="GPU Images CUDA 12" %}}
173173

174174
| Description | Quay | Docker Hub |
175175
| --- | --- |-------------------------------------------------------------|
176-
| Latest images from the branch (development) | `quay.io/go-skynet/local-ai:master-gpu-nvidia-cuda12` | `localai/localai:master-gpu-nvidia-cuda12` |
176+
| Latest images from the branch (development) | `quay.io/go-skynet/local-ai:master-gpu-nvidia-cuda-12` | `localai/localai:master-gpu-nvidia-cuda12` |
177177
| Latest tag | `quay.io/go-skynet/local-ai:latest-gpu-nvidia-cuda-12` | `localai/localai:latest-gpu-nvidia-cuda-12` |
178-
| Versioned image | `quay.io/go-skynet/local-ai:{{< version >}}-gpu-nvidia-cuda12` | `localai/localai:{{< version >}}-gpu-nvidia-cuda12` |
178+
| Versioned image | `quay.io/go-skynet/local-ai:{{< version >}}-gpu-nvidia-cuda-12` | `localai/localai:{{< version >}}-gpu-nvidia-cuda-12` |
179179

180180
{{% /tab %}}
181181

‎docs/static/install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -672,7 +672,7 @@ install_docker() {
672672
-d -p $PORT:8080 --name local-ai localai/localai:$IMAGE_TAG $STARTCOMMAND
673673
elif [ "$HAS_CUDA" ]; then
674674
# Default to CUDA 12
675-
IMAGE_TAG=${LOCALAI_VERSION}-gpu-nvidia-cuda12
675+
IMAGE_TAG=${LOCALAI_VERSION}-gpu-nvidia-cuda-12
676676
# AIO
677677
if [ "$USE_AIO" = true ]; then
678678
IMAGE_TAG=${LOCALAI_VERSION}-aio-gpu-nvidia-cuda-12

0 commit comments

Comments
 (0)