Skip to content

Commit 0b7265e

Browse files
authored
feat: prefer the simpler delete to avoid the admin API (#636)
Closes: SYNC-4155
1 parent b0ffa8c commit 0b7265e

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

  • autopush-common/src/db/bigtable/bigtable_client

autopush-common/src/db/bigtable/bigtable_client/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -492,6 +492,7 @@ impl BigTableClientImpl {
492492
/// This will drop ALL data associated with these rows.
493493
/// Note that deletion may take up to a week to occur.
494494
/// see https://cloud.google.com/php/docs/reference/cloud-bigtable/latest/Admin.V2.DropRowRangeRequest
495+
#[allow(unused)]
495496
async fn delete_rows(&self, row_key: &str) -> Result<bool, error::BigTableError> {
496497
let admin = BigtableTableAdminClient::new(self.pool.get_channel()?);
497498
let mut req = DropRowRangeRequest::new();
@@ -774,7 +775,7 @@ impl DbClient for BigTableClientImpl {
774775

775776
async fn remove_user(&self, uaid: &Uuid) -> DbResult<()> {
776777
let row_key = uaid.simple().to_string();
777-
self.delete_rows(&row_key).await?;
778+
self.delete_row(&row_key).await?;
778779
Ok(())
779780
}
780781

0 commit comments

Comments
 (0)