Skip to content

Commit e41f5bb

Browse files
authored
test(NODE-3719,NODE-3543): fix unified runner to not pass uri opts in object and unskip lb tests (#3133)
1 parent c289eef commit e41f5bb

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

test/integration/load-balancers/load_balancers.spec.test.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,19 @@ const SKIP = [
77
// Verified they use the same connection but the Node implementation executes
88
// a getMore before the killCursors even though the stream is immediately
99
// closed.
10+
// TODO(NODE-3970): implement and reference a node specific integration test for this
1011
'change streams pin to a connection',
11-
'errors during the initial connection hello are ignore',
1212

13-
// NOTE: The following three tests are skipped pending a decision made on DRIVERS-1847, since
14-
// pinning the connection on any getMore error is very awkward in node and likely results
15-
// in sub-optimal pinning.
13+
// TODO(DRIVERS-1847): The following three tests are skipped pending a decision made on DRIVERS-1847,
14+
// since pinning the connection on any getMore error is very awkward in node and likely results
15+
// in sub-optimal pinning.
1616
'pinned connections are not returned after an network error during getMore',
1717
'pinned connections are not returned to the pool after a non-network error on getMore',
1818
'stale errors are ignored',
19-
// NOTE: The driver correctly fails these 2 tests in non LB mode for server versions greater than 3.4.
20-
// In versions that are 3.4 or less an error still occurs but a different one (connection closes).
21-
// TODO(NODE-3543): fix the path-ing that will produce errors for older servers
22-
'operations against non-load balanced clusters fail if URI contains loadBalanced=true',
23-
'operations against non-load balanced clusters succeed if URI contains loadBalanced=false',
2419

20+
// This test is skipped because it assumes drivers attempt connections on the first operation,
21+
// but Node has a connect() method that is called before the first operation is ever run.
22+
// TODO(NODE-2149): Refactor connect()
2523
'errors during the initial connection hello are ignored',
2624

2725
...(process.env.SERVERLESS

test/tools/unified-spec-runner/entities.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ export class UnifiedMongoClient extends MongoClient {
101101
constructor(uri: string, description: ClientEntity) {
102102
super(uri, {
103103
monitorCommands: true,
104-
...description.uriOptions,
105104
...getEnvironmentalOptions(),
106105
...(description.serverApi ? { serverApi: description.serverApi } : {})
107106
});

0 commit comments

Comments
 (0)