Skip to content

fix(chrome-devtools): fix sharedInfo conflict with userOptions.sharedInfo cause hmr fail #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

nyqykk
Copy link
Contributor

@nyqykk nyqykk commented Jun 14, 2024

…Info cause hmr fail

Description

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 0d06e4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@module-federation/devtools Patch
@module-federation/runtime Patch
@module-federation/enhanced Patch
@module-federation/rspack Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
3008-runtime-remote Patch
@module-federation/modernjs Patch
@module-federation/utilities Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 0d06e4d
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/666bf39d4fd5e200088d36b9
😎 Deploy Preview https://deploy-preview-2612--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zhoushaw zhoushaw merged commit 8671892 into main Jun 14, 2024
9 checks passed
@zhoushaw zhoushaw deleted the fix/devtool-hmr-shared branch June 14, 2024 09:13
@2heal1 2heal1 mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants