chore: bump CI to use 20.19.4, 22.18.0, 24.6.0 (#5430)

Author: mark-wiemer

.github/workflows/mocha.yml

@@ -66,9 +66,8 @@ jobs:
     with:
       os: 'ubuntu-latest,windows-latest'
       # We pin exact versions here per https://github.com/mochajs/mocha/issues/5052
-      # Use 20.18.3 per https://github.com/mochajs/mocha/issues/5278
       # Ref https://nodejs.org/en/about/previous-releases
-      node-versions: '18.20.8,20.18.3,22.17.1,24.4.1'
+      node-versions: '18.20.8,20.19.4,22.18.0,24.6.0'
       npm-script: test-node:${{ matrix.test-part }}
       coverage: ${{ matrix.coverage }}
 

test/integration/plugins/root-hooks.spec.js

@@ -153,7 +153,7 @@ describe('root hooks', function () {
         // (introduced in Node 20.10.0, 21.1.0)
         // newer versions of Node no longer fail :)
         if (isNewerVersion(process.versions.node)) {
-          return true; // skip test on newer Node versions
+          return true; // skip suite on newer Node versions
         }
 
         const filename =
@@ -200,7 +200,7 @@ describe('root hooks', function () {
 
       describe('on newer versions, should work', function () {
         if (!isNewerVersion(process.versions.node)) {
-          return true; // skip test on older Node versions
+          return true; // skip suite on older Node versions
         }
 
         const filename =
@@ -227,7 +227,7 @@ describe('root hooks', function () {
             invokeMochaAsync(
               [
                 '--require=' + require.resolve(filename), // as object
-                 // enabled by default in these newer versions, but clearer to use it explicitly
+                // enabled by default in these newer versions, but clearer to use it explicitly
                 '--experimental-detect-module'
               ],
               'pipe'

test/node-unit/reporters/parallel-buffered.spec.js

@@ -21,8 +21,10 @@ const {
 const {EventEmitter} = require('node:events');
 const sinon = require('sinon');
 const rewiremock = require('rewiremock/node');
+const semver = require('semver');
 
 describe('ParallelBuffered', function () {
+  /** @type {EventEmitter} */
   let runner;
   let ParallelBuffered;
 
@@ -102,7 +104,19 @@ describe('ParallelBuffered', function () {
     describe('on EVENT_RUN_END', function () {
       it('should remove all listeners', function () {
         runner.emit(EVENT_RUN_END);
-        expect(runner.listeners(), 'to be empty');
+        // Some node versions throw instead of returning `[]` due to a bug
+        // Fix is in Node ^22.14 and ^24.0, but not yet backported to 20 as of writing
+        // Problem was introduced in 20.19.0, not present in 20.18.3
+        // https://github.com/nodejs/node/issues/56263
+        const nodeVersionThrows = semver.satisfies(
+          process.versions.node,
+          '^20.19.0 || >=22.0.0 <22.14.0'
+        );
+        if (nodeVersionThrows) {
+          expect(runner.listeners, 'to throw');
+        } else {
+          expect(runner.listeners(), 'to be empty');
+        }
       });
     });