Skip to content

Commit daf2add

Browse files
committed
build: rework ASAN build on Actions
Changed from Debug build to Release build to avoid out of memory issues during the link step. This should also speed up the build. Commented out the test runner for now, since there are too many ASAN warnings there to be useful. We should re-enable the test runner once our ASAN warnings are fixed. Simplify the environment: instead of running on a container, runs directly on the host. With this, ASAN build looks identical to other builds in GitHub Actions, with the exception of the `--enable-asan` flag. Ref: https://github.com/nodejs/node/issue/32257 Ref: nodejs#32324
1 parent 6a34901 commit daf2add

File tree

1 file changed

+16
-20
lines changed

1 file changed

+16
-20
lines changed

.github/workflows/ASAN.yml

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,19 @@ name: node ASAN
33
on: [push, pull_request]
44

55
jobs:
6-
ubuntu-build:
7-
runs-on: ubuntu-latest
8-
container: gengjiawen/node-build:2020-02-14
9-
steps:
10-
- uses: actions/checkout@v2
11-
- name: Build
12-
# TODO(mmarchini): With V8 8.1, GitHub Actions doesn't have enough
13-
# memory to build with debug and ASAN. Allow this build to fail until
14-
# we figure out a workaround, or until we update to 8.2 (where build
15-
# is passing).
16-
continue-on-error: true
17-
run: |
18-
npx envinfo
19-
./configure --debug --enable-asan --ninja && ninja -C out/Debug
20-
- name: Test
21-
env:
22-
ASAN_OPTIONS: halt_on_error=0
23-
continue-on-error: true
24-
run: |
25-
python3 tools/test.py -J --mode=debug
6+
build-linux-asan:
7+
runs-on: ubuntu-latest
8+
steps:
9+
- uses: actions/checkout@v2
10+
- name: Environment Information
11+
run: npx envinfo
12+
- name: Build
13+
run: ./configure --enable-asan && make -j2
14+
# TODO(mmarchini): re-enable tests when we fix all issues pointed out
15+
# by ASAN
16+
# - name: Test
17+
# env:
18+
# ASAN_OPTIONS: halt_on_error=0
19+
# continue-on-error: true
20+
# run: |
21+
# python3 tools/test.py -J

0 commit comments

Comments
 (0)