Skip to content

[Diffusion] Benchmark updates #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaywonchung merged 1 commit into from
Nov 29, 2025
Merged

[Diffusion] Benchmark updates #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions configs/xdit/text-to-image/benchmark.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,33 +12,33 @@ command_template: |
--workload.ring_degree {ring_degree}

sweep_defaults:
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [1]
ring_degree: [1]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [1]
ring_degree: [2]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [2]
ring_degree: [1]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [1]
ring_degree: [4]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [2]
ring_degree: [2]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [4]
ring_degree: [1]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [1]
ring_degree: [8]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [2]
ring_degree: [4]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [4]
ring_degree: [2]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [8]
ring_degree: [1]
20 changes: 10 additions & 10 deletions configs/xdit/text-to-video/benchmark.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,34 +12,34 @@ command_template: |
--workload.ring_degree {ring_degree}

sweep_defaults:
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [1]
ring_degree: [1]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [1]
ring_degree: [2]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [2]
ring_degree: [1]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [1]
ring_degree: [4]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [2]
ring_degree: [2]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [4]
ring_degree: [1]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [1]
ring_degree: [8]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [2]
ring_degree: [4]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [4]
ring_degree: [2]
- batch_size: [1, 2, 4, 8, 16, 32]
- batch_size: [1, 2, 4, 8, 16]
ulysses_degree: [8]
ring_degree: [1]

Expand Down
6 changes: 2 additions & 4 deletions scripts/generate_jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,18 +815,16 @@ def generate_xdit_slurm_script(
f"#SBATCH --output=logs/{dataset}_{gpu_model}_{num_gpus}gpu_{model_slug}_%j.out",
f"#SBATCH --error=logs/{dataset}_{gpu_model}_{num_gpus}gpu_{model_slug}_%j.err",
"",
"set -e",
"set -v",
"",
"# Change to submission directory",
"cd $SLURM_SUBMIT_DIR",
"",
"# Load Python, CUDA, and GCC",
"module load python/3.12.1 && \\",
"module load cuda/12.6.3 && \\",
"module load cuda/12.8.1 && \\",
"module load gcc",
"",
"source .venv/bin/activate",
"",
"# Ensure required environment variables are set",
'if [[ -z "$HF_HOME" ]]; then',
' echo "ERROR: HF_HOME environment variable is not set. Please export HF_HOME before running sbatch." >&2',
Expand Down