Skip to content

Commit 30d1819

Browse files
byrootdeivid-rodriguez
authored andcommitted
Add Ruby 3.1 support
Add net-smtp as a dependency for Ruby 3.1 compatibility It was recently removed from the default gems: - https://bugs.ruby-lang.org/issues/17873 - ruby/ruby#4530 Also add net-imap and net-pop to the gemspec JRuby already has prerelease support for `io-wait` as a gem, and an almost ready PR to also support `strscan` as a gem, dependencies introduced by this change. Adding both to the Gemfile gets `bundle install` to succeed, although specs fail later because Bundler does not seem to support pointing to a java extension gem through git.
1 parent 5aa0106 commit 30d1819

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ jobs:
2323
timeout: 5
2424
- ruby: '3.0'
2525
timeout: 5
26+
- ruby: 3.1
27+
timeout: 5
2628
- ruby: jruby
2729
timeout: 5
2830
- ruby: truffleruby

Gemfile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,10 @@ gem 'mini_mime'
1515
gem 'byebug', :platforms => :mri
1616

1717
gem "psych", "< 4"
18+
19+
if RUBY_PLATFORM == "java"
20+
gem "io-wait", "0.2.2.pre1"
21+
gem "strscan", github: "https://github.com/ruby/strscan/pull/25"
22+
else
23+
gem "io-wait"
24+
end

mail.gemspec

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ Gem::Specification.new do |s|
1616
s.required_ruby_version = ">= 2.5"
1717

1818
s.add_dependency('mini_mime', '>= 0.1.1')
19+
s.add_dependency('net-smtp')
20+
s.add_dependency('net-imap')
21+
s.add_dependency('net-pop')
1922

2023
s.add_development_dependency('bundler', '>= 1.0.3')
2124
s.add_development_dependency('rake', '> 0.8.7')

0 commit comments

Comments
 (0)