stringToTTL: error when overflowing uint32 (#1698)

* stringToTTL: error when overflowing uint32

Signed-off-by: Miek Gieben <miek@miek.nl>

* update template

Signed-off-by: Miek Gieben <miek@miek.nl>

---------

Signed-off-by: Miek Gieben <miek@miek.nl>

Author: miekg

.github/pull_request_template.md

@@ -1,6 +1,8 @@
 Thanks for you pull request, do note the following:
 
-* If your PR introduces backward incompatible changes it will very likely not be merged.
+- If your PR introduces backward incompatible changes it will very likely not be merged.
 
-* We support the last two major Go versions, if your PR uses features from a too new Go version, it
-    will not be merged.
+- We support the last two major Go versions, if your PR uses features from a too new Go version, it
+  will not be merged.
+
+- If this text is not replaced (deleted, or preferably replaced with something sensible), your PR will be closed.

scan.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"io"
 	"io/fs"
+	"math"
 	"os"
 	"path"
 	"path/filepath"
@@ -1231,7 +1232,7 @@ func typeToInt(token string) (uint16, bool) {
 
 // stringToTTL parses things like 2w, 2m, etc, and returns the time in seconds.
 func stringToTTL(token string) (uint32, bool) {
-	var s, i uint32
+	var s, i uint
 	for _, c := range token {
 		switch c {
 		case 's', 'S':
@@ -1251,12 +1252,15 @@ func stringToTTL(token string) (uint32, bool) {
 			i = 0
 		case '0', '1', '2', '3', '4', '5', '6', '7', '8', '9':
 			i *= 10
-			i += uint32(c) - '0'
+			i += uint(c) - '0'
 		default:
 			return 0, false
 		}
 	}
-	return s + i, true
+	if s+i > math.MaxUint32 {
+		return 0, false
+	}
+	return uint32(s + i), true
 }
 
 // Parse LOC records' <digits>[.<digits>][mM] into a