Fix poetry discovery (#20181)

Author: Kartik Raj

src/client/extensionActivation.ts

@@ -46,7 +46,6 @@ import { registerTypes as tensorBoardRegisterTypes } from './tensorBoard/service
 import { registerTypes as commonRegisterTerminalTypes } from './terminals/serviceRegistry';
 import { ICodeExecutionManager, ITerminalAutoActivation } from './terminals/types';
 import { registerTypes as unitTestsRegisterTypes } from './testing/serviceRegistry';
-import { registerTypes as interpretersRegisterTypes } from './interpreter/serviceRegistry';
 
 // components
 import * as pythonEnvironments from './pythonEnvironments';
@@ -131,7 +130,6 @@ async function activateLegacy(ext: ExtensionState): Promise<ActivationResult> {
     // Feature specific registrations.
     unitTestsRegisterTypes(serviceManager);
     lintersRegisterTypes(serviceManager);
-    interpretersRegisterTypes(serviceManager);
     formattersRegisterTypes(serviceManager);
     installerRegisterTypes(serviceManager);
     commonRegisterTerminalTypes(serviceManager);

src/client/extensionInit.ts

@@ -10,6 +10,7 @@ import { STANDARD_OUTPUT_CHANNEL } from './common/constants';
 import { registerTypes as platformRegisterTypes } from './common/platform/serviceRegistry';
 import { registerTypes as processRegisterTypes } from './common/process/serviceRegistry';
 import { registerTypes as commonRegisterTypes } from './common/serviceRegistry';
+import { registerTypes as interpretersRegisterTypes } from './interpreter/serviceRegistry';
 import {
     GLOBAL_MEMENTO,
     IDisposableRegistry,
@@ -85,6 +86,7 @@ export function initializeStandard(ext: ExtensionState): void {
     variableRegisterTypes(serviceManager);
     platformRegisterTypes(serviceManager);
     processRegisterTypes(serviceManager);
+    interpretersRegisterTypes(serviceManager);
 
     // We will be pulling other code over from activateLegacy().
 }

src/client/pythonEnvironments/common/environmentManagers/poetry.ts

@@ -142,10 +142,14 @@ export class Poetry {
         traceVerbose(`Getting poetry for cwd ${cwd}`);
         // Produce a list of candidate binaries to be probed by exec'ing them.
         function* getCandidates() {
-            const customPoetryPath = getPythonSetting<string>('poetryPath');
-            if (customPoetryPath && customPoetryPath !== 'poetry') {
-                // If user has specified a custom poetry path, use it first.
-                yield customPoetryPath;
+            try {
+                const customPoetryPath = getPythonSetting<string>('poetryPath');
+                if (customPoetryPath && customPoetryPath !== 'poetry') {
+                    // If user has specified a custom poetry path, use it first.
+                    yield customPoetryPath;
+                }
+            } catch (ex) {
+                traceError(`Failed to get poetry setting`, ex);
             }
             // Check unqualified filename, in case it's on PATH.
             yield 'poetry';