Add GoogleTest failure pattern to default ctest failurePatterns (#4756)

* Initial plan

* Add GoogleTest failure pattern to default ctest failurePatterns

Add a third default failure pattern `(.*?):(\\d+): *(Failure.*)` that matches
GoogleTest's output format (e.g., `file.cpp:135: Failure`). The existing
patterns only matched lines containing `error:`, which doesn't match
GoogleTest's failure format, resulting in non-clickable file paths in the
Test Results panel.

Fixes #4589

Co-authored-by: hanniavalera <90047725+hanniavalera@users.noreply.github.com>

* Restore .npmrc file that was accidentally deleted

Co-authored-by: hanniavalera <90047725+hanniavalera@users.noreply.github.com>

* Fix GoogleTest test assertions to avoid cross-platform URI path issues

On Linux CI, vscode.Uri.file('D:/...').path returns '/D:/...' (with leading
slash), causing assertion failures. Use Unix-style paths in test cases since
the tests validate regex pattern matching, not URI path handling.

Co-authored-by: hanniavalera <90047725+hanniavalera@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: hanniavalera <90047725+hanniavalera@users.noreply.github.com>

Author: Copilot

CHANGELOG.md

@@ -17,6 +17,7 @@ Improvements:
 - Allow preset modification commands to target CMakeUserPresets.json. The target file is determined by the focused editor, or by prompting the user when both files exist. [#4564](https://github.com/microsoft/vscode-cmake-tools/issues/4564)
 
 Bug Fixes:
+- Fix Test Results panel not hyperlinking file paths for GoogleTest failures. The default `cmake.ctest.failurePatterns` now includes a pattern matching GoogleTest's `file:line: Failure` output format. [#4589](https://github.com/microsoft/vscode-cmake-tools/issues/4589)
 - Fix wrong path created for artifact when parsing code model using CMake File API. [#3015](https://github.com/microsoft/vscode-cmake-tools/issues/3015)
 - Fix garbled characters (Mojibake) in the Output panel when MSVC outputs UTF-8 (e.g., with `/utf-8`) on non-UTF-8 Windows systems. When `cmake.outputLogEncoding` is `auto`, the build output is now validated as UTF-8 before falling back to the system code page. [#4520](https://github.com/microsoft/vscode-cmake-tools/issues/4520)
 - Fix CMakePresets.json discovery failing in multi-folder workspaces when the presets file is in a subdirectory specified by `cmake.sourceDirectory`. [#4727](https://github.com/microsoft/vscode-cmake-tools/issues/4727)

package.json

@@ -2528,6 +2528,9 @@
             },
             {
               "regexp": "(.*?)\\((\\d+)\\): *(?:error: *)(.*)"
+            },
+            {
+              "regexp": "(.*?):(\\d+): *(Failure.*)"
             }
           ],
           "markdownDescription": "%cmake-tools.configuration.cmake.ctest.failurePatterns.markdownDescription%",

test/unit-tests/ctest.test.ts

@@ -67,6 +67,38 @@ suite('CTest test', () => {
         assertMessageFields(result6, '/path/to/file', 46, 0, 'the message', undefined, undefined);
     });
 
+    test('Find GoogleTest failure patterns in output', () => {
+        // Default patterns from package.json
+        const defaultPatterns = [
+            { regexp: '(.*?):(\\d+): *(?:error: *)(.*)' },
+            { regexp: '(.*?)\\((\\d+)\\): *(?:error: *)(.*)' },
+            { regexp: '(.*?):(\\d+): *(Failure.*)' }
+        ];
+
+        // GoogleTest failure format
+        const gtestOutput = '/path/to/TestFile.cpp:135: Failure\nValue of: expr\n  Actual: true\nExpected: false\n';
+        const gtestResults = searchOutputForFailures(defaultPatterns, gtestOutput);
+        expect(gtestResults.length).to.eq(1);
+        assertMessageFields(gtestResults[0], '/path/to/TestFile.cpp', 134, 0, 'Failure', undefined, undefined);
+
+        // GCC/Clang error format still works (no regression)
+        const gccOutput = '/path/to/file.cpp:10: error: undefined reference\n';
+        const gccResults = searchOutputForFailures(defaultPatterns, gccOutput);
+        expect(gccResults.length).to.eq(1);
+        assertMessageFields(gccResults[0], '/path/to/file.cpp', 9, 0, 'undefined reference', undefined, undefined);
+
+        // MSVC error format still works (no regression)
+        const msvcOutput = '/project/file.cpp(20): error: something went wrong\n';
+        const msvcResults = searchOutputForFailures(defaultPatterns, msvcOutput);
+        expect(msvcResults.length).to.eq(1);
+        assertMessageFields(msvcResults[0], '/project/file.cpp', 19, 0, 'something went wrong', undefined, undefined);
+
+        // Lines without "Failure" or "error:" should not match
+        const noMatchOutput = '[ RUN      ] MyTest.TestCase\n[  PASSED  ] 1 test.\n';
+        const noMatchResults = searchOutputForFailures(defaultPatterns, noMatchOutput);
+        expect(noMatchResults.length).to.eq(0);
+    });
+
     function assertMessageFields(
         tm: TestMessage,
         file: string, line: number, column: number, message: string,