Breaking Change: Remove SyncTasks from reactxp core and prefer ES6 promises (#1129)

* Remove SyncTasks from reactxp core and prefer ES6 promises
Usage of ES6 promises is more standardized, using SyncTasks by default doesn't provide many consumers a large benefit. If they need SyncTasks promises, they can wrap in SyncTasks.fromThenable at the use site

* Update reactxp-netinfo to remove SyncTasks

* Update samples to use ES6 promises

Author: berickson1

extensions/netinfo/package.json

@@ -9,8 +9,7 @@
     "tslint": "tslint -p tsconfig.json -r tslint.json -r ./node_modules/tslint-microsoft-contrib --fix || true"
   },
   "dependencies": {
-    "@react-native-community/netinfo": "^3.2.0",
-    "synctasks": "^0.3.3"
+    "@react-native-community/netinfo": "^3.2.0"
   },
   "peerDependencies": {
     "reactxp": "^2.0.0-rc.1",

extensions/netinfo/src/common/Interfaces.ts

@@ -8,14 +8,13 @@
  * info. This was extracted from the reactxp core
  */
 
-import * as SyncTasks from 'synctasks';
 import SubscribableEvent from 'subscribableevent';
 
 import * as Types from './Types';
 
 export abstract class NetInfo {
-    abstract isConnected(): SyncTasks.Promise<boolean>;
-    abstract getType(): SyncTasks.Promise<Types.DeviceNetworkType>;
+    abstract isConnected(): Promise<boolean>;
+    abstract getType(): Promise<Types.DeviceNetworkType>;
     connectivityChangedEvent = new SubscribableEvent<(isConnected: boolean) => void>();
 }
 

extensions/netinfo/src/native-common/NetInfo.tsx

@@ -8,7 +8,6 @@
  */
 
 import * as RNNetInfo from '@react-native-community/netinfo';
-import * as SyncTasks from 'synctasks';
 
 import * as Types from '../common/Types';
 import * as Interfaces from '../common/Interfaces';
@@ -24,20 +23,16 @@ export class NetInfo extends Interfaces.NetInfo {
         RNNetInfo.addEventListener(onEventOccurredHandler);
     }
 
-    isConnected(): SyncTasks.Promise<boolean> {
-        const deferred = SyncTasks.Defer<boolean>();
-
-        RNNetInfo.fetch().then((state: RNNetInfo.NetInfoState) => {
-            deferred.resolve(state.isConnected);
+    isConnected(): Promise<boolean> {
+        return RNNetInfo.fetch().then((state: RNNetInfo.NetInfoState) => {
+            return state.isConnected;
         }).catch(() => {
-            deferred.reject('NetInfo.isConnected.fetch() failed');
+            return Promise.reject('NetInfo.isConnected.fetch() failed');
         });
-
-        return deferred.promise();
     }
 
-    getType(): SyncTasks.Promise<Types.DeviceNetworkType> {
-        return SyncTasks.fromThenable(RNNetInfo.fetch()).then((state: RNNetInfo.NetInfoState) => {
+    getType(): Promise<Types.DeviceNetworkType> {
+        return RNNetInfo.fetch().then((state: RNNetInfo.NetInfoState) => {
             return NetInfo._getNetworkTypeFromConnectionInfo(state);
         });
     }

extensions/netinfo/src/web/NetInfo.tsx

@@ -7,8 +7,6 @@
  * Web-specific implementation of the cross-platform Video abstraction.
  */
 
-import * as SyncTasks from 'synctasks';
-
 import * as Types from '../common/Types';
 import * as Interfaces from '../common/Interfaces';
 
@@ -27,12 +25,12 @@ export class NetInfo extends Interfaces.NetInfo {
         }
     }
 
-    isConnected(): SyncTasks.Promise<boolean> {
-        return SyncTasks.Resolved(navigator.onLine);
+    isConnected(): Promise<boolean> {
+        return Promise.resolve(navigator.onLine);
     }
 
-    getType(): SyncTasks.Promise<Types.DeviceNetworkType> {
-        return SyncTasks.Resolved(Types.DeviceNetworkType.Unknown);
+    getType(): Promise<Types.DeviceNetworkType> {
+        return Promise.resolve(Types.DeviceNetworkType.Unknown);
     }
 }
 

extensions/netinfo/tsconfig.json

@@ -11,6 +11,7 @@
         "strict": true,
         "outDir": "dist/",
         "lib": [
+            "es2015.promise",
             "es5",
             "dom"
         ],

package-lock.json

@@ -15,8 +15,7 @@
     "lodash": "^4.17.15",
     "prop-types": "^15.7.2",
     "rebound": "^0.1.0",
-    "subscribableevent": "^1.0.1",
-    "synctasks": "^0.3.3"
+    "subscribableevent": "^1.0.1"
   },
   "peerDependencies": {
     "react": "^16.0",

package.json

@@ -20,7 +20,7 @@ export class ImageStore extends StoreBase {
     private _searchQuery = '';
     private _images: Image[] = [];
 
-    private _request: SyncTasks.STPromise<void> | null = null;
+    private _request: SyncTasks.Promise<void> | null = null;
 
     @autoSubscribe
     getImages() {
@@ -68,7 +68,7 @@ export class ImageStore extends StoreBase {
         this._request = this._searchImages(searchQuery);
     }
 
-    private _searchImages(query: string): SyncTasks.STPromise<void> {
+    private _searchImages(query: string): SyncTasks.Promise<void> {
         return GiphyClient.searchImages(query)
             .then(images => {
                 this._images = images;

samples/ImageList/src/stores/ImageStore.ts

@@ -158,7 +158,7 @@ class LocationView extends RX.Component<RX.CommonProps, LocationState> {
                     polledPositionHistory: this.state.polledPositionHistory +
                         '(' + this._formatError(err.code as RX.Types.LocationErrorType) + ')\n'
                 });
-            }).always(() => {
+            }).finally(() => {
                 sampleCount++;
                 if (sampleCount < totalSamplesInTest) {
                     _.delay(() => {

samples/RXPTest/src/Tests/LocationTest.tsx

@@ -4,10 +4,10 @@
 
 import _ = require('lodash');
 import RX = require('reactxp');
-import RXNetInfo, { Types as RXNetInfoTypes } from 'reactxp-netinfo'
+import RXNetInfo, { Types as RXNetInfoTypes } from 'reactxp-netinfo';
 
 import * as CommonStyles from '../CommonStyles';
-import { Test, TestResult, TestType } from '../Test';
+import { Test, TestType } from '../Test';
 
 const _styles = {
     container: RX.Styles.createViewStyle({