Skip to content

Commit 9aa216c

Browse files
Skn0ttpavelfeldman
authored andcommitted
cherry-pick(#39994): Revert "fix(windows): hide console window when spawning browser processes"
1 parent 01b2b15 commit 9aa216c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

packages/playwright-core/src/server/utils/processLauncher.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ export async function launchProcess(options: LaunchProcessOptions): Promise<Laun
136136
// process group, making it possible to kill child process tree with `.kill(-pid)` command.
137137
// @see https://nodejs.org/api/child_process.html#child_process_options_detached
138138
detached: process.platform !== 'win32',
139-
windowsHide: true,
140139
env: options.env,
141140
cwd: options.cwd,
142141
shell: options.shell,
@@ -234,7 +233,7 @@ export async function launchProcess(options: LaunchProcessOptions): Promise<Laun
234233
// Force kill the browser.
235234
try {
236235
if (process.platform === 'win32') {
237-
const taskkillProcess = childProcess.spawnSync(`taskkill /pid ${spawnedProcess.pid} /T /F`, { shell: true, windowsHide: true });
236+
const taskkillProcess = childProcess.spawnSync(`taskkill /pid ${spawnedProcess.pid} /T /F`, { shell: true });
238237
const [stdout, stderr] = [taskkillProcess.stdout.toString(), taskkillProcess.stderr.toString()];
239238
if (stdout)
240239
options.log(`[pid=${spawnedProcess.pid}] taskkill stdout: ${stdout}`);

0 commit comments

Comments
 (0)