fix "no-shadow"

Author: layershifter

build/gulp/plugins/gulp-component-menu-behaviors.ts

@@ -20,8 +20,8 @@ type BehaviorMenuItem = {
 }
 
 const getTextFromCommentToken = (commentTokens, tokenTitle): string => {
-  const token = commentTokens.find(token => token.title === tokenTitle)
-  return token ? token.description : ''
+  const resultToken = commentTokens.find(token => token.title === tokenTitle)
+  return resultToken ? resultToken.description : ''
 }
 
 export default () => {

build/gulp/tasks/docs.ts

@@ -25,10 +25,10 @@ const { paths } = config
 const g = require('gulp-load-plugins')()
 const { colors, log } = g.util
 
-const handleWatchChange = path => log(`File ${path} was changed, running tasks...`)
-const handleWatchUnlink = (group, path) => {
-  log(`File ${path} was deleted, running tasks...`)
-  remember.forget(group, path)
+const handleWatchChange = changedPath => log(`File ${changedPath} was changed, running tasks...`)
+const handleWatchUnlink = (group, changedPath) => {
+  log(`File ${changedPath} was deleted, running tasks...`)
+  remember.forget(group, changedPath)
 }
 
 // ----------------------------------------
@@ -224,7 +224,7 @@ task('watch:docs', cb => {
   // rebuild example menus
   watch(examplesIndexSrc, series('build:docs:example-menu'))
     .on('change', handleWatchChange)
-    .on('unlink', path => handleWatchUnlink('example-menu', path))
+    .on('unlink', changedPath => handleWatchUnlink('example-menu', changedPath))
 
   watch(examplesSrc, series('build:docs:example-sources'))
     .on('change', handleWatchChange)
@@ -241,7 +241,7 @@ task('watch:docs', cb => {
 
   watch(behaviorSrc, series('build:docs:component-menu-behaviors'))
     .on('change', handleWatchChange)
-    .on('unlink', path => handleWatchUnlink('component-menu-behaviors', path))
+    .on('unlink', changedPath => handleWatchUnlink('component-menu-behaviors', changedPath))
 
   // rebuild images
   watch(`${config.paths.docsSrc()}/**/*.{png,jpg,gif}`, series('build:docs:images')).on(

build/gulp/tasks/perf.ts

@@ -72,9 +72,9 @@ const normalizeMeasures = (measures: ProfilerMeasureCycle[]): NormalizedMeasures
     {},
   )
 
-  return _.mapValues(perExampleMeasures, (measures: ProfilerMeasure[]) => ({
-    actualTime: reduceMeasures(measures, 'actualTime'),
-    baseTime: reduceMeasures(measures, 'baseTime'),
+  return _.mapValues(perExampleMeasures, (profilerMeasures: ProfilerMeasure[]) => ({
+    actualTime: reduceMeasures(profilerMeasures, 'actualTime'),
+    baseTime: reduceMeasures(profilerMeasures, 'baseTime'),
   }))
 }
 
@@ -139,7 +139,7 @@ task('perf:build', cb => {
 task('perf:run', async () => {
   const measures: ProfilerMeasureCycle[] = []
   const times = (argv.times as string) || DEFAULT_RUN_TIMES
-  const filter = argv.filter
+  const pathFilter = argv.filter
 
   const bar = process.env.CI
     ? { tick: _.noop }
@@ -159,7 +159,7 @@ task('perf:run', async () => {
       const page = await browser.newPage()
       await page.goto(`http://${config.server_host}:${config.perf_port}`)
 
-      const measuresFromStep = await page.evaluate(filter => window.runMeasures(filter), filter)
+      const measuresFromStep = await page.evaluate(filter => window.runMeasures(filter), pathFilter)
       measures.push(measuresFromStep)
       bar.tick()
 

build/gulp/tasks/stats.ts

@@ -46,9 +46,9 @@ const semverCmp = (a, b) => {
   return 0
 }
 
-function webpackAsync(config): Promise<any> {
+function webpackAsync(webpackConfig): Promise<any> {
   return new Promise((resolve, reject) => {
-    const compiler = webpack(config)
+    const compiler = webpack(webpackConfig)
     compiler.run((err, stats) => {
       const statsJson = stats.toJson()
       const { errors, warnings } = statsJson
@@ -73,14 +73,14 @@ function webpackAsync(config): Promise<any> {
 
 async function compileOneByOne(allConfigs) {
   let assets = []
-  for (const config of allConfigs) {
-    log('Compiling', config.output.filename)
+  for (const webpackConfig of allConfigs) {
+    log('Compiling', webpackConfig.output.filename)
     try {
-      const result = await webpackAsync(config)
+      const result = await webpackAsync(webpackConfig)
       assets = [...assets, ...result.assets]
       log('Done', result.assets[0].name) // All builds should produce just single asset
     } catch (err) {
-      log('Error', config.output.filename)
+      log('Error', webpackConfig.output.filename)
       throw err
     }
   }

build/gulp/tasks/test-projects.tsx

@@ -23,7 +23,7 @@ const log = (context: string) => (message: string) => {
   console.log('='.repeat(80))
 }
 
-export const runIn = path => cmd => sh(`cd ${path} && ${cmd}`)
+export const runIn = targetPath => cmd => sh(`cd ${targetPath} && ${cmd}`)
 
 const addResolutionPathsForStardustPackages = async (
   testProjectDir: string,

build/gulp/tasks/test-vulns.ts

@@ -14,9 +14,9 @@ const SCAN_RESULTS_DIR_PATH = paths.base(SCAN_RESULTS_DIR_NAME)
 const log = message => debug.log(message)
 log.success = message => debug.log(`✔ ${message}`)
 
-const ensureDirExists = path => {
-  if (!fs.existsSync(path)) {
-    sh(`mkdir -p ${path}`)
+const ensureDirExists = directoryPath => {
+  if (!fs.existsSync(directoryPath)) {
+    sh(`mkdir -p ${directoryPath}`)
   }
 }
 

config.ts

@@ -36,10 +36,10 @@ const paths = {
   dll: base.bind(null, envConfig.dir_dll),
   docsDist: base.bind(null, envConfig.dir_docs_dist),
   docsSrc: base.bind(null, envConfig.dir_docs_src),
-  packageDist: (packageName: string, ...paths: string[]) =>
-    base(envConfig.dir_packages, packageName, 'dist', ...paths),
-  packageSrc: (packageName: string, ...paths: string[]) =>
-    base(envConfig.dir_packages, packageName, 'src', ...paths),
+  packageDist: (packageName: string, ...passedPaths: string[]) =>
+    base(envConfig.dir_packages, packageName, 'dist', ...passedPaths),
+  packageSrc: (packageName: string, ...passedPaths: string[]) =>
+    base(envConfig.dir_packages, packageName, 'src', ...passedPaths),
   packages: base.bind(null, envConfig.dir_packages),
   perfDist: base.bind(null, envConfig.dir_perf_dist),
   perfSrc: base.bind(null, envConfig.dir_perf_src),

docs/src/components/ComponentDoc/ComponentControls/ComponentControlsCodeSandbox/ComponentControlsCodeSandbox.tsx

@@ -86,13 +86,13 @@ class ComponentControlsShowCode extends React.Component<
         skipRedirect
         template={template}
       >
-        {({ isLoading, isDeploying, active }) => {
+        {({ isLoading, isDeploying, active: isActive }) => {
           const loading = isLoading || isDeploying
           return (
             <LabelledButton
               iconName={loading ? 'spinner' : 'connectdevelop'}
               label={loading ? 'Exporting...' : 'CodeSandbox'}
-              active={active}
+              active={isActive}
             />
           )
         }}

docs/src/components/ComponentDoc/PerfChart/PerfDataProvider.tsx

@@ -27,8 +27,8 @@ const PerfDataProvider: React.FC = ({ children }) => {
           setData(responseJson)
           setLoading(false)
         })
-        .catch(error => {
-          setError(error)
+        .catch(e => {
+          setError(e)
           setLoading(false)
         })
     }

docs/src/components/ComponentPlayground.tsx

@@ -13,12 +13,12 @@ type ComponentPlaygroundProps = {
 }
 
 const ComponentPlayground: React.FunctionComponent<ComponentPlaygroundProps> = props => {
-  const playgroundPath = _.find(playgroundPaths, playgroundPath =>
+  const resultPath = _.find(playgroundPaths, playgroundPath =>
     _.includes(playgroundPath, `/${props.componentName}/`),
   )
 
-  if (playgroundPath) {
-    const PlaygroundComponent: React.FunctionComponent = examplePlaygroundContext(playgroundPath)
+  if (resultPath) {
+    const PlaygroundComponent: React.FunctionComponent = examplePlaygroundContext(resultPath)
       .default
 
     return (