Commit 93a0f09
committed
Fix(mcp): drain pending command futures on actor failure; add Streamable HTTP test
- In `McpSessionActor._run_actor`, when an outer exception occurs (e.g., session
startup failure), drain `_command_queue` and set exceptions on any pending
command futures. This prevents callers from hanging indefinitely when the actor
fails before processing queued commands. Draining is best‑effort and guarded.
- Propagate the same exception to `_shutdown_future` when present.
- Add unit test `test_run_actor_drains_queue_on_session_exception` using
`StreamableHttpServerParams` with an invalid URL to trigger a startup failure
and assert pending futures are failed.
This hardens failure handling and makes client behavior predictable under
connection errors.1 parent f76f92d commit 93a0f09
2 files changed
Lines changed: 55 additions & 1 deletion
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
262 | 262 | | |
263 | 263 | | |
264 | 264 | | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
265 | 278 | | |
266 | 279 | | |
267 | 280 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
553 | 553 | | |
554 | 554 | | |
555 | 555 | | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
556 | 597 | | |
557 | 598 | | |
558 | 599 | | |
| |||
0 commit comments