Skip to content

Fix NPEs in Distribute#1509

Merged
MatkovIvan merged 11 commits intodevelopfrom
fix/Distribute-NPE-unknown-sources
Mar 12, 2021
Merged

Fix NPEs in Distribute#1509
MatkovIvan merged 11 commits intodevelopfrom
fix/Distribute-NPE-unknown-sources

Conversation

@Jamminroot
Copy link
Copy Markdown
Contributor

@Jamminroot Jamminroot commented Mar 5, 2021 •
edited
Loading

Please have a look at our guidelines for contributions and consider the following before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?
  • Did you check UI tests on the sample app? They are not executed on CI.

Description

This PR fixes NPE in edge case in Distribute module

Related PRs or issues

AB#85361
#1477

@Jamminroot Jamminroot changed the title Fix NPE in Distribute: unknown sources Fix NPEs in Distribute Mar 5, 2021
@DmitriyKirakosyan DmitriyKirakosyan self-requested a review March 5, 2021 12:05
AnastasiaKubova
AnastasiaKubova reviewed Mar 5, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated
guperrot
guperrot reviewed Mar 5, 2021
View reviewed changes
Comment thread sdk/appcenter-distribute/src/main/java/com/microsoft/appcenter/distribute/Distribute.java Outdated
Update sdk/appcenter-distribute/src/test/java/com/microsoft/appcenter…
578e40d 
…/distribute/DistributeCustomizationTest.java
guperrot
guperrot reviewed Mar 9, 2021
View reviewed changes
Comment thread ...distribute/src/test/java/com/microsoft/appcenter/distribute/DistributeCustomizationTest.java Outdated
Comment thread ...distribute/src/test/java/com/microsoft/appcenter/distribute/DistributeCustomizationTest.java
Comment thread ...distribute/src/test/java/com/microsoft/appcenter/distribute/DistributeCustomizationTest.java
Comment thread sdk/appcenter-distribute/src/test/java/com/microsoft/appcenter/distribute/DistributeTest.java Outdated
MatkovIvan
MatkovIvan reviewed Mar 11, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated
guperrot
guperrot previously approved these changes Mar 11, 2021
View reviewed changes
@guperrot guperrot dismissed their stale review March 11, 2021 20:30

Letting the dev team approve

@MatkovIvan MatkovIvan merged commit ab45fca into develop Mar 12, 2021
@MatkovIvan MatkovIvan deleted the fix/Distribute-NPE-unknown-sources branch March 12, 2021 05:38
This was referenced Mar 18, 2021
Closed
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnastasiaKubova AnastasiaKubova Awaiting requested review from AnastasiaKubova

@DmitriyKirakosyan DmitriyKirakosyan Awaiting requested review from DmitriyKirakosyan

2 more reviewers

@MatkovIvan MatkovIvan MatkovIvan approved these changes

@guperrot guperrot guperrot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Jamminroot @DmitriyKirakosyan @guperrot @MatkovIvan @AnastasiaKubova