Skip to content

Fix(49473): Added docs for RegExpMatchArray #49499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 21, 2022

Conversation

Grubba27
Copy link
Contributor

Fixes #49473
The change broke some tests 😢
gulp runtests:
Captura de Tela 2022-06-11 às 17 21 08

Captura de Tela 2022-06-11 às 16 51 07

for some reason gulp baseline-accept & gulp baseline-accept-wrc does not update the lib package. Maybe I`m missing some gulp command in between ?
I ran gulp LKG but it updated ~ 92 files ~ I should have commited them ?

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jun 11, 2022
@Grubba27 Grubba27 changed the title fix: Added docs for RegExpMatchArray #49473 fix: Added docs for RegExpMatchArray Jun 11, 2022
@Grubba27 Grubba27 changed the title fix: Added docs for RegExpMatchArray fix(49473): Added docs for RegExpMatchArray Jun 12, 2022
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jun 13, 2022

for some reason gulp baseline-accept & gulp baseline-accept-wrc does not update the lib package.

The baselines get generated in tests/baselines/local, and the baseline-accept command copies them into tests/baselines/reference. When you're ready, you need to stage them and commit them in git.

So the TL;DR is that you need to run:

gulp baseline-acept
git add tests/baselines/
git commit -m "Accepted baselines."

@Grubba27 Grubba27 changed the title fix(49473): Added docs for RegExpMatchArray Fix(49473): Added docs for RegExpMatchArray Jun 13, 2022
@DanielRosenwasser
Copy link
Member

Looks like there are some baselines you missed since merging from main (promisePermutations, promisePermutations2, promisePermutations3, duplicateNumericIndexers).

@sandersn sandersn merged commit 9f2ab7f into microsoft:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

No documentation on the RegExpMatchArray type
4 participants