Replace addUndefined in serializeTypeForDeclaration with the actual declaration (#58085)

Author: weswigham

src/compiler/checker.ts

@@ -638,7 +638,7 @@ export function transformDeclarations(context: TransformationContext) {
             case SyntaxKind.PropertyDeclaration:
             case SyntaxKind.BindingElement:
             case SyntaxKind.VariableDeclaration:
-                typeNode = resolver.createTypeOfDeclaration(node, enclosingDeclaration, declarationEmitNodeBuilderFlags, symbolTracker, shouldAddImplicitUndefined);
+                typeNode = resolver.createTypeOfDeclaration(node, enclosingDeclaration, declarationEmitNodeBuilderFlags, symbolTracker);
                 break;
             case SyntaxKind.FunctionDeclaration:
             case SyntaxKind.ConstructSignature:

src/compiler/transformers/declarations.ts

@@ -5653,7 +5653,7 @@ export interface EmitResolver {
     requiresAddingImplicitUndefined(node: ParameterDeclaration): boolean;
     isExpandoFunctionDeclaration(node: FunctionDeclaration): boolean;
     getPropertiesOfContainerFunction(node: Declaration): Symbol[];
-    createTypeOfDeclaration(declaration: AccessorDeclaration | VariableLikeDeclaration | PropertyAccessExpression | ElementAccessExpression | BinaryExpression, enclosingDeclaration: Node, flags: NodeBuilderFlags, tracker: SymbolTracker, addUndefined?: boolean): TypeNode | undefined;
+    createTypeOfDeclaration(declaration: AccessorDeclaration | VariableLikeDeclaration | PropertyAccessExpression | ElementAccessExpression | BinaryExpression, enclosingDeclaration: Node, flags: NodeBuilderFlags, tracker: SymbolTracker): TypeNode | undefined;
     createReturnTypeOfSignatureDeclaration(signatureDeclaration: SignatureDeclaration, enclosingDeclaration: Node, flags: NodeBuilderFlags, tracker: SymbolTracker): TypeNode | undefined;
     createTypeOfExpression(expr: Expression, enclosingDeclaration: Node, flags: NodeBuilderFlags, tracker: SymbolTracker): TypeNode | undefined;
     createLiteralConstValue(node: VariableDeclaration | PropertyDeclaration | PropertySignature | ParameterDeclaration, tracker: SymbolTracker): Expression;

src/compiler/types.ts

@@ -35,15 +35,15 @@ class Board {
 >this.ships.every(function (val) { return val.isSunk; }) : boolean
 >                                                        : ^^^^^^^
 >this.ships.every : { <S extends Ship>(predicate: (value: Ship, index: number, array: Ship[]) => value is S, thisArg?: any): this is S[]; (predicate: (value: Ship, index: number, array: Ship[]) => unknown, thisArg?: any): boolean; }
->                 : ^^^^^^^^^^^^^^^^^^^         ^^^     ^^^^^^^^     ^^^^^^^^^^     ^^^^^^^^^^^^^^^^^^^^^^^^^       ^^^^^^^^^^^^^^^^^^^^^^^         ^^^     ^^^^^^^^     ^^^^^^^^^^     ^^^^^^^^^^^^^^^^^^^^^^       ^^^^^^^^^^^^^^^^^^^
+>                 : ^^^^^^^^^^^^^^^^^^^         ^^^     ^^^^^^^^     ^^      ^^     ^^^^^^^^^^^^^^^^^^^^^^^^^       ^^^   ^^^^^^^^^^^^^^^^^         ^^^     ^^^^^^^^     ^^      ^^     ^^^^^^^^^^^^^^^^^^^^^^       ^^^   ^^^^^^^^^^^^^
 >this.ships : Ship[]
 >           : ^^^^^^
 >this : this
 >     : ^^^^
 >ships : Ship[]
 >      : ^^^^^^
 >every : { <S extends Ship>(predicate: (value: Ship, index: number, array: Ship[]) => value is S, thisArg?: any): this is S[]; (predicate: (value: Ship, index: number, array: Ship[]) => unknown, thisArg?: any): boolean; }
->      : ^^^^^^^^^^^^^^^^^^^         ^^^     ^^^^^^^^     ^^^^^^^^^^     ^^^^^^^^^^^^^^^^^^^^^^^^^       ^^^^^^^^^^^^^^^^^^^^^^^         ^^^     ^^^^^^^^     ^^^^^^^^^^     ^^^^^^^^^^^^^^^^^^^^^^       ^^^^^^^^^^^^^^^^^^^
+>      : ^^^^^^^^^^^^^^^^^^^         ^^^     ^^^^^^^^     ^^      ^^     ^^^^^^^^^^^^^^^^^^^^^^^^^       ^^^   ^^^^^^^^^^^^^^^^^         ^^^     ^^^^^^^^     ^^      ^^     ^^^^^^^^^^^^^^^^^^^^^^       ^^^   ^^^^^^^^^^^^^
 >function (val) { return val.isSunk; } : (val: Ship) => boolean
 >                                      : ^   ^^^^^^^^^^^^^^^^^^
 >val : Ship

tests/baselines/reference/1.0lib-noErrors.types

@@ -39,11 +39,11 @@ module clodule {
 >clodule.sfn('a') : number
 >                 : ^^^^^^
 >clodule.sfn : (id: string) => number
->            : ^  ^^^^^^^^^^^^^^^^^^^
+>            : ^  ^^      ^^^^^^^^^^^
 >clodule : typeof clodule
 >        : ^^^^^^^^^^^^^^
 >sfn : (id: string) => number
->    : ^  ^^^^^^^^^^^^^^^^^^^
+>    : ^  ^^      ^^^^^^^^^^^
 >'a' : "a"
 >    : ^^^
     }

tests/baselines/reference/2dArrays.types

@@ -17,11 +17,11 @@ for (var v of ['a', 'b', 'c']) {
 >console.log(v) : void
 >               : ^^^^
 >console.log : (...data: any[]) => void
->            : ^^^^    ^^^^^^^^^^^^^^^^
+>            : ^^^^    ^^     ^^^^^^^^^
 >console : Console
 >        : ^^^^^^^
 >log : (...data: any[]) => void
->    : ^^^^    ^^^^^^^^^^^^^^^^
+>    : ^^^^    ^^     ^^^^^^^^^
 >v : string
 >  : ^^^^^^
 }

tests/baselines/reference/ClassAndModuleThatMergeWithModulesExportedStaticFunctionUsingClassPrivateStatics.types

@@ -23,11 +23,11 @@ for (var x of [1, 2, 3]) {
 >console.log(x) : void
 >               : ^^^^
 >console.log : (...data: any[]) => void
->            : ^^^^    ^^^^^^^^^^^^^^^^
+>            : ^^^^    ^^     ^^^^^^^^^
 >console : Console
 >        : ^^^^^^^
 >log : (...data: any[]) => void
->    : ^^^^    ^^^^^^^^^^^^^^^^
+>    : ^^^^    ^^     ^^^^^^^^^
 >x : number
 >  : ^^^^^^
 }

tests/baselines/reference/ES5For-of1.types

@@ -23,11 +23,11 @@ for (var x of [1, 2, 3]) {
 >console.log(x) : void
 >               : ^^^^
 >console.log : (...data: any[]) => void
->            : ^^^^    ^^^^^^^^^^^^^^^^
+>            : ^^^^    ^^     ^^^^^^^^^
 >console : Console
 >        : ^^^^^^^
 >log : (...data: any[]) => void
->    : ^^^^    ^^^^^^^^^^^^^^^^
+>    : ^^^^    ^^     ^^^^^^^^^
 >x : number
 >  : ^^^^^^
 }

tests/baselines/reference/ES5For-of22.types

@@ -17,11 +17,11 @@ for (var v of ['a', 'b', 'c']) {
 >console.log(v) : void
 >               : ^^^^
 >console.log : (...data: any[]) => void
->            : ^^^^    ^^^^^^^^^^^^^^^^
+>            : ^^^^    ^^     ^^^^^^^^^
 >console : Console
 >        : ^^^^^^^
 >log : (...data: any[]) => void
->    : ^^^^    ^^^^^^^^^^^^^^^^
+>    : ^^^^    ^^     ^^^^^^^^^
 >v : string
 >  : ^^^^^^
 }