Skip to content

Commit 2fb9ab7

Browse files
author
Arthur Ozga
committed
repond to feedback
1 parent c1d466a commit 2fb9ab7

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

src/compiler/checker.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ namespace ts {
110110
getParameterType: getTypeAtPosition,
111111
getReturnTypeOfSignature,
112112
getNonNullableType,
113-
getBaseTypeVariableOfClass,
114113
typeToTypeNode: nodeBuilder.typeToTypeNode,
115114
indexInfoToIndexSignatureDeclaration: nodeBuilder.indexInfoToIndexSignatureDeclaration,
116115
signatureToSignatureDeclaration: nodeBuilder.signatureToSignatureDeclaration,

src/compiler/types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2530,7 +2530,6 @@ namespace ts {
25302530
*/
25312531
/* @internal */ getParameterType(signature: Signature, parameterIndex: number): Type;
25322532
getNonNullableType(type: Type): Type;
2533-
/* @internal */ getBaseTypeVariableOfClass(symbol: Symbol): Type | undefined;
25342533

25352534
/** Note that the resulting nodes cannot be checked. */
25362535
typeToTypeNode(type: Type, enclosingDeclaration?: Node, flags?: NodeBuilderFlags): TypeNode;

src/services/codefixes/fixAddMissingMember.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ namespace ts.codefix {
4949
const symbol = leftExpressionType.symbol;
5050
if (symbol.flags & SymbolFlags.Class) {
5151
classDeclaration = symbol.declarations && <ClassLikeDeclaration>symbol.declarations[0];
52-
if (getObjectFlags(leftExpressionType) & ObjectFlags.Anonymous && symbol.flags & SymbolFlags.Class && !checker.getBaseTypeVariableOfClass(symbol)) {
52+
if (leftExpressionType !== checker.getDeclaredTypeOfSymbol(symbol)) {
53+
// The expression is a class symbol but the type is not the instance-side.
5354
makeStatic = true;
5455
}
5556
}

0 commit comments

Comments
 (0)