Minor cleanup, ensure multiple emit helpers for outfile tests

Author: rbuckton

src/compiler/factory/emitHelpers.ts

@@ -617,34 +617,6 @@ namespace ts {
             };`
     };
 
-    /** @deprecated To be removed in TS >= 4.3, as it may be referenced in a tsbuildinfo */
-    export const spreadHelper: UnscopedEmitHelper = {
-        name: "typescript:spread",
-        importName: "__spread",
-        scoped: false,
-        dependencies: [readHelper],
-        text: `
-            var __spread = (this && this.__spread) || function () {
-                for (var ar = [], i = 0; i < arguments.length; i++) ar = ar.concat(__read(arguments[i]));
-                return ar;
-            };`
-    };
-
-    /** @deprecated To be removed in TS >= 4.3, as it may be referenced in a tsbuildinfo */
-    export const spreadArraysHelper: UnscopedEmitHelper = {
-        name: "typescript:spreadArrays",
-        importName: "__spreadArrays",
-        scoped: false,
-        text: `
-            var __spreadArrays = (this && this.__spreadArrays) || function () {
-                for (var s = 0, i = 0, il = arguments.length; i < il; i++) s += arguments[i].length;
-                for (var r = Array(s), k = 0, i = 0; i < il; i++)
-                    for (var a = arguments[i], j = 0, jl = a.length; j < jl; j++, k++)
-                        r[k] = a[j];
-                return r;
-            };`
-    };
-
     export const spreadArrayHelper: UnscopedEmitHelper = {
         name: "typescript:spreadArray",
         importName: "__spreadArray",
@@ -888,8 +860,6 @@ namespace ts {
             awaiterHelper,
             extendsHelper,
             templateObjectHelper,
-            spreadHelper,
-            spreadArraysHelper,
             spreadArrayHelper,
             valuesHelper,
             readHelper,
@@ -920,4 +890,11 @@ namespace ts {
                 return name => cache[name] || (cache[name] = { get value() { return geti(name); }, set value(v) { seti(name, v); } });
             })(name => super[name], (name, value) => super[name] = value);`
     };
+
+    export function isCallToHelper(firstSegment: Expression, helperName: __String) {
+        return isCallExpression(firstSegment)
+            && isIdentifier(firstSegment.expression)
+            && (getEmitFlags(firstSegment.expression) & EmitFlags.HelperName)
+            && firstSegment.expression.escapedText === helperName;
+    }
 }

src/compiler/transformers/es2015.ts

@@ -3892,6 +3892,8 @@ namespace ts {
          *
          * @param elements The array of Expression nodes.
          * @param needsUniqueCopy A value indicating whether to ensure that the result is a fresh array.
+         * This should be `true` when spreading into an `ArrayLiteral`, and `false` when spreading into an
+         * argument list.
          * @param multiLine A value indicating whether the result should be emitted on multiple lines.
          */
         function transformAndSpreadElements(elements: NodeArray<Expression>, needsUniqueCopy: boolean, multiLine: boolean, hasTrailingComma: boolean): Expression {
@@ -3916,6 +3918,15 @@ namespace ts {
             //
             // [output]
             //      __spreadArray(__spreadArray([], a), [b])
+            //
+            // NOTE: We use `isPackedArrayLiteral` below rather than just `isArrayLiteral`
+            // because ES2015 spread will replace _missing_ array elements with `undefined`,
+            // so we cannot just use an array as is. For example:
+            //
+            // `[1, ...[2, , 3]]` becomes `[1, 2, undefined, 3]`
+            //
+            // However, for packed array literals (i.e., an array literal with no OmittedExpression
+            // elements), we can use the array as-is.
 
             // Map spans of spread expressions into their expressions and spans of other
             // expressions into an array literal.
@@ -3926,46 +3937,35 @@ namespace ts {
                 )
             );
 
-            const helpers = emitHelpers();
             if (segments.length === 1) {
                 const firstSegment = segments[0];
-                if (!needsUniqueCopy
-                    || isPackedArrayLiteral(firstSegment)
+                // If we don't need a unique copy, then we are spreading into an argument list for
+                // a CallExpression or NewExpression. When using `--downlevelIteration`, we need
+                // to coerce this into an array for use with `apply`, so we will use the code path
+                // that follows instead.
+                if (!needsUniqueCopy && !compilerOptions.downlevelIteration
+                    || isPackedArrayLiteral(firstSegment) // see NOTE (above)
                     || isCallToHelper(firstSegment, "___spreadArray" as __String)) {
                     return segments[0];
                 }
             }
 
+            const helpers = emitHelpers();
             const startsWithSpread = isSpreadElement(elements[0]);
             let expression: Expression =
                 startsWithSpread ? factory.createArrayLiteralExpression() :
                 segments[0];
             for (let i = startsWithSpread ? 0 : 1; i < segments.length; i++) {
                 expression = helpers.createSpreadArrayHelper(
                     expression,
-                    compilerOptions.downlevelIteration && !isArrayLiteralExpression(segments[i]) ?
+                    compilerOptions.downlevelIteration && !isPackedArrayLiteral(segments[i]) ? // see NOTE (above)
                         helpers.createReadHelper(segments[i], /*count*/ undefined) :
                         segments[i]);
             }
 
             return expression;
         }
 
-        function isPackedElement(node: Expression) {
-            return !isOmittedExpression(node);
-        }
-
-        function isPackedArrayLiteral(node: Expression) {
-            return isArrayLiteralExpression(node) && every(node.elements, isPackedElement);
-        }
-
-        function isCallToHelper(firstSegment: Expression, helperName: __String) {
-            return isCallExpression(firstSegment)
-                && isIdentifier(firstSegment.expression)
-                && (getEmitFlags(firstSegment.expression) & EmitFlags.HelperName)
-                && firstSegment.expression.escapedText === helperName;
-        }
-
         function partitionSpread(node: Expression) {
             return isSpreadElement(node)
                 ? visitSpanOfSpreads

src/compiler/utilities.ts

@@ -7033,6 +7033,17 @@ namespace ts {
         }
     }
 
+    function isPackedElement(node: Expression) {
+        return !isOmittedExpression(node);
+    }
+
+    /**
+     * Determines whether the provided node is an ArrayLiteralExpression that contains no missing elements.
+     */
+    export function isPackedArrayLiteral(node: Expression) {
+        return isArrayLiteralExpression(node) && every(node.elements, isPackedElement);
+    }
+
     /**
      * Indicates whether the result of an `Expression` will be unused.
      *

src/testRunner/unittests/tsbuild/helpers.ts

@@ -615,7 +615,8 @@ const { b, ...rest } = { a: 10, b: 30, yy: 30 };
         const content = fs.readFileSync(path, "utf8");
         fs.writeFileSync(path, `${content}
 function ${project}${file}Spread(...b: number[]) { }
-${project}${file}Spread(...[10, 20, 30]);`);
+const ${project}${file}_ar = [20, 30];
+${project}${file}Spread(10, ...${project}${file}_ar);`);
 
         replaceText(fs, `src/${project}/tsconfig.json`, `"strict": false,`, `"strict": false,
     "downlevelIteration": true,`);

tests/baselines/reference/destructuringParameterDeclaration3ES5iterable.js

@@ -111,7 +111,7 @@ function a11(_a) {
 var array = [1, 2, 3];
 var array2 = [true, false, "hello"];
 a2(__spreadArray([], __read(array)));
-a1.apply(void 0, array);
+a1.apply(void 0, __spreadArray([], __read(array)));
 a9([1, 2, [["string"]], false, true]); // Parameter type is [any, any, [[any]]]
 a10([1, 2, [["string"]], false, true]); // Parameter type is any[]
 a10([1, 2, 3, false, true]); // Parameter type is any[]