Skip to content

Commit 06e32d5

Browse files
committed
Remove like/dislike from tab order when not visible
Fixes 1515517 and 1515523
1 parent 760f5f6 commit 06e32d5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/typescriptlang-org/src/templates/documentation.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ const HandbookTemplate: React.FC<Props> = (props) => {
9696
<section id="doc-layout" >
9797
<SidebarToggleButton />
9898

99-
<div className="page-popup" id="page-helpful-popup" style={{ opacity: 0 }}>
99+
<div className="page-popup" id="page-helpful-popup" style={{ opacity: 0, display: "none" }}>
100100
<p>Was this page helpful?</p>
101101
<div>
102102
<button className="first" id="like-button-popup" title="Like this page"><LikeUnfilledSVG /></button>

packages/typescriptlang-org/src/templates/scripts/setupLikeDislikeButtons.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export const setupLikeDislikeButtons = (slug: string, i: any) => {
5555

5656
const popupOpacity = bottomOfWindow ? "1" : "0"
5757
if (popup.style.opacity != popupOpacity) {
58-
// popup.style.display = bottomOfWindow ? "block" : "none"
58+
popup.style.display = bottomOfWindow ? "block" : "none"
5959
popup.style.opacity = popupOpacity
6060
}
6161

0 commit comments

Comments
 (0)