update parser error recovery tests to use ¬ not #

The intent of the tests seemed to be to
regiment the behavior of the parser
when a weird symbol is encountered.

The `#` is now taken by private identifiers,
so `¬` seems like a good new choice for
keeping the diff small, since it also fits in
16 bits (wide emojis would be treated
as multiple characters, since the scanner
uses ++).

Signed-off-by: Max Heiber <[email protected]>

Author: mheiber

src/compiler/parser.ts

@@ -2242,7 +2242,7 @@ namespace ts {
                     break;
                 }
                 dotPos = scanner.getStartPos();
-                entity = createQualifiedName(entity, parseRightSideOfDot(allowReservedWords));
+                entity = createQualifiedName(entity, parseRightSideOfDot(allowReservedWords, /* allowPrivateNames */ false) as Identifier);
             }
             return entity;
         }
@@ -2254,7 +2254,7 @@ namespace ts {
             return finishNode(node);
         }
 
-        function parseRightSideOfDot(allowIdentifierNames: boolean): Identifier {
+        function parseRightSideOfDot(allowIdentifierNames: boolean, allowPrivateNames: boolean): Identifier | PrivateName {
             // Technically a keyword is valid here as all identifiers and keywords are identifier names.
             // However, often we'll encounter this in error situations when the identifier or keyword
             // is actually starting another valid construct.
@@ -2285,6 +2285,10 @@ namespace ts {
                 }
             }
 
+            if (allowPrivateNames && token() === SyntaxKind.PrivateName) {
+                return parsePrivateName();
+            }
+
             return allowIdentifierNames ? parseIdentifierName() : parseIdentifier();
         }
 
@@ -4358,7 +4362,8 @@ namespace ts {
             const node = <PropertyAccessExpression>createNode(SyntaxKind.PropertyAccessExpression, expression.pos);
             node.expression = expression;
             parseExpectedToken(SyntaxKind.DotToken, Diagnostics.super_must_be_followed_by_an_argument_list_or_member_access);
-            node.name = parseRightSideOfDot(/*allowIdentifierNames*/ true);
+            // private names will never work with `super` (`super.#foo`), but that's a semantic error, not syntactic
+            node.name = parseRightSideOfDot(/*allowIdentifierNames*/ true, /*allowPrivateNames*/ true);
             return finishNode(node);
         }
 
@@ -4529,7 +4534,7 @@ namespace ts {
             while (parseOptional(SyntaxKind.DotToken)) {
                 const propertyAccess: JsxTagNamePropertyAccess = <JsxTagNamePropertyAccess>createNode(SyntaxKind.PropertyAccessExpression, expression.pos);
                 propertyAccess.expression = expression;
-                propertyAccess.name = parseRightSideOfDot(/*allowIdentifierNames*/ true);
+                propertyAccess.name = parseRightSideOfDot(/*allowIdentifierNames*/ true, /*allowPrivateNames*/ true);
                 expression = finishNode(propertyAccess);
             }
             return expression;
@@ -4646,7 +4651,8 @@ namespace ts {
             const propertyAccess = <PropertyAccessExpression>createNode(SyntaxKind.PropertyAccessExpression, expression.pos);
             propertyAccess.expression = expression;
             propertyAccess.questionDotToken = questionDotToken;
-            propertyAccess.name = parseRightSideOfDot(/*allowIdentifierNames*/ true);
+            propertyAccess.name = parseRightSideOfDot(/*allowIdentifierNames*/ true, /*allowPrivateNames*/ true);
+
             if (questionDotToken || expression.flags & NodeFlags.OptionalChain) {
                 propertyAccess.flags |= NodeFlags.OptionalChain;
             }

tests/baselines/reference/MemberFunctionDeclaration8_es6.errors.txt

@@ -9,7 +9,7 @@ tests/cases/conformance/es6/memberFunctionDeclarations/MemberFunctionDeclaration
     class C {
       foo() {
         // Make sure we don't think of *bar as the start of a generator method.
-        if (a) # * bar;
+        if (a) ¬ * bar;
             ~
 !!! error TS2304: Cannot find name 'a'.
 

tests/baselines/reference/MemberFunctionDeclaration8_es6.js

@@ -2,7 +2,7 @@
 class C {
   foo() {
     // Make sure we don't think of *bar as the start of a generator method.
-    if (a) # * bar;
+    if (a) ¬ * bar;
     return bar;
   }
 }

tests/baselines/reference/MemberFunctionDeclaration8_es6.symbols

@@ -6,7 +6,7 @@ class C {
 >foo : Symbol(C.foo, Decl(MemberFunctionDeclaration8_es6.ts, 0, 9))
 
     // Make sure we don't think of *bar as the start of a generator method.
-    if (a) # * bar;
+    if (a) ¬ * bar;
     return bar;
   }
 }

tests/baselines/reference/MemberFunctionDeclaration8_es6.types

@@ -6,7 +6,7 @@ class C {
 >foo : () => any
 
     // Make sure we don't think of *bar as the start of a generator method.
-    if (a) # * bar;
+    if (a) ¬ * bar;
 >a : any
 > : any
 >* bar : number

tests/baselines/reference/parseErrorInHeritageClause1.errors.txt

@@ -3,7 +3,7 @@ tests/cases/compiler/parseErrorInHeritageClause1.ts(1,19): error TS1127: Invalid
 
 
 ==== tests/cases/compiler/parseErrorInHeritageClause1.ts (2 errors) ====
-    class C extends A # {
+    class C extends A ¬ {
                     ~
 !!! error TS2304: Cannot find name 'A'.
 

tests/baselines/reference/parseErrorInHeritageClause1.js

@@ -1,5 +1,5 @@
 //// [parseErrorInHeritageClause1.ts]
-class C extends A # {
+class C extends A ¬ {
 }
 
 //// [parseErrorInHeritageClause1.js]

tests/baselines/reference/parseErrorInHeritageClause1.symbols

@@ -1,4 +1,4 @@
 === tests/cases/compiler/parseErrorInHeritageClause1.ts ===
-class C extends A # {
+class C extends A ¬ {
 >C : Symbol(C, Decl(parseErrorInHeritageClause1.ts, 0, 0))
 }

tests/baselines/reference/parseErrorInHeritageClause1.types

@@ -1,5 +1,5 @@
 === tests/cases/compiler/parseErrorInHeritageClause1.ts ===
-class C extends A # {
+class C extends A ¬ {
 >C : C
 >A : any
 }

tests/baselines/reference/parserErrorRecovery_Block2.errors.txt

@@ -3,7 +3,7 @@ tests/cases/conformance/parser/ecmascript5/ErrorRecovery/Blocks/parserErrorRecov
 
 ==== tests/cases/conformance/parser/ecmascript5/ErrorRecovery/Blocks/parserErrorRecovery_Block2.ts (1 errors) ====
     function f() {
-        #
+        ¬
 
 !!! error TS1127: Invalid character.
         return;