Appease perl-critic in recently edited files

Author: rwstauner

lib/MetaCPAN/Server/Diff.pm

@@ -44,12 +44,12 @@ has relative => (
 
 sub _build_raw {
     my $self = shift;
-    my $raw  = "";
+    my $raw  = q[];
     run3(
         [
             $self->git,
             qw(diff --no-renames -z --no-index -u --no-color --numstat),
-            "--relative=" . $self->relative,
+            '--relative=' . $self->relative,
             $self->source,
             $self->target
         ],
@@ -80,7 +80,7 @@ sub _build_structured {
 
     while ( my $line = shift @lines ) {
         my ( $insertions, $deletions ) = split( /\t/, $line );
-        my $segment = "";
+        my $segment = q[];
         while ( my $diff = shift @raw ) {
 
             # only run it through if non-ascii bytes are found

lib/MetaCPAN/Server/QuerySanitizer.pm

@@ -34,7 +34,7 @@ our %metacpan_scripts = (
 sub _build_clean_query {
     my ($self) = @_;
     my $search = $self->query
-        or return undef;
+        or return;
 
     _scan_hash_tree($search);
 

t/perl-critic.t

@@ -46,7 +46,6 @@ my %skip = map { ( $_ => 1 ) } qw(
     lib/MetaCPAN/Script/Watcher.pm
     lib/MetaCPAN/Server/Controller.pm
     lib/MetaCPAN/Server/Controller/Changes.pm
-    lib/MetaCPAN/Server/Controller/Diff.pm
     lib/MetaCPAN/Server/Controller/File.pm
     lib/MetaCPAN/Server/Controller/Login.pm
     lib/MetaCPAN/Server/Controller/Login/PAUSE.pm
@@ -55,10 +54,8 @@ my %skip = map { ( $_ => 1 ) } qw(
     lib/MetaCPAN/Server/Controller/Search/Autocomplete.pm
     lib/MetaCPAN/Server/Controller/Source.pm
     lib/MetaCPAN/Server/Controller/User/Favorite.pm
-    lib/MetaCPAN/Server/Diff.pm
     lib/MetaCPAN/Server/Model/CPAN.pm
     lib/MetaCPAN/Server/Model/Source.pm
-    lib/MetaCPAN/Server/QuerySanitizer.pm
     lib/MetaCPAN/Server/View/JSON.pm
     lib/MetaCPAN/Server/View/Pod.pm
     lib/MetaCPAN/Util.pm