chore(cloud-function): send X-Robots-Tag: noindex on pimg#13503
Merged
chore(cloud-function): send X-Robots-Tag: noindex on pimg#13503
X-Robots-Tag: noindex on pimg#13503Conversation
Contributor
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
caugner
commented
Sep 16, 2025
Contributor
Author
|
Verified working on stage, now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
We have seen some ad images being indexed by Google.
Solution
Send
X-Robots-Tag: noindex, nofollowon the images.While we're here, we also:
console.warn()to distinguish the different error cases in the server logs,PS: In theory,
nofollowon an image doesn't make sense, but in theory the fetch endpoint could also return SVG or similar with links included.How did you test this change?
Deploying to stage: https://github.com/mdn/yari/actions/runs/17761632422