Skip to content

Add Wio-H725AE #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 21, 2023
Merged

Add Wio-H725AE #133

merged 12 commits into from
Feb 21, 2023

Conversation

JohnK1987
Copy link
Member

@JohnK1987 JohnK1987 commented Feb 18, 2023

Summary of changes

This PR will add Wio-H725AE target into MbedOS.

Were done:

  • New general clock configuration for STM32H725
  • New clock configuration via system_clock_override.c just for Wio-H725AE
  • Correction the memory settings according to STM32H723
  • New board specific files related to pinout
  • Added the board specific configuration in targets.json file
  • MCU page with Wio-H725AE details (more in section Documentation bellow)
  • Upload method configuration for this target

Impact of changes

I do not see any negative impact or impact to rest of MbedOS.

Migration actions required

N/A

Documentation

https://github.com/mbed-ce/mbed-os/wiki/MCU-Info-Page:-STM32H725xE


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

I made Greentea test and two test failed. However I found it is related to the whole STM32 or just the H7 family and not just this board specifically. For more see https://github.com/mbed-ce/mbed-os/wiki/MCU-Info-Page:-STM32H725xE#known-issues


Reviewers

@JojoS62, @multiplemonomials - I do not understand memory settings (linker scripts) so please, be so kind and check mainly that. It is just copy of STM32H723.


@JojoS62
Copy link

JojoS62 commented Feb 18, 2023

At the moment I’m handicapped and can not help with the review. I have also ordered this target but still waiting for delivery.
The linker file should work, but for MCUs with complex bus/memory structures, it is hard to have one that fits all. The good thing is, Mbed-CE can have application specific linker files.

@JohnK1987 JohnK1987 removed the request for review from JojoS62 February 18, 2023 10:18
@JohnK1987
Copy link
Member Author

JohnK1987 commented Feb 18, 2023

Thank you for the info Jojo.
Yeah, I understand and I hope I will be able to modify linker script for external memories in the future (I need to learn something more about that), but for now I am glad for basic functionality.

BR, Jan

Copy link
Collaborator

@multiplemonomials multiplemonomials left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a few things

Copy link
Collaborator

@multiplemonomials multiplemonomials left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, it looks great!

@multiplemonomials multiplemonomials merged commit fb47f59 into mbed-ce:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants