Properly tear down the reachabilityRef in RCTNetInfo

Mehdi Mulani · facebook-github-bot · commit a7ddcf85de9c · 2018-03-19T11:00:23.000-07:00
Summary: The pull request that added this (facebook#17397) simply forgot to remove the callback, which would cause crashes if the RCTNetInfo module was ever deallocated. While that usually doesn't happen in apps, it can if the user logs out and you need to wipe all the RCT modules (to remove user data, for instance). Reviewed By: PeteTheHeat Differential Revision: D7322999 fbshipit-source-id: e49ec7311b39920f7b7743a5854c0dda1dbccc73
diff --git a/RCTNetInfo.m b/RCTNetInfo.m
@@ -164,6 +164,7 @@ - (BOOL)setReachabilityStatus:(SCNetworkReachabilityFlags)flags
                   reject:(__unused RCTPromiseRejectBlock)reject)
 {
   SCNetworkReachabilityRef reachability = [self getReachabilityRef];
+  SCNetworkReachabilityUnscheduleFromRunLoop(reachability, CFRunLoopGetMain(), kCFRunLoopCommonModes);
   CFRelease(reachability);
   resolve(@{@"connectionType": _connectionType ?: RCTConnectionTypeUnknown,
             @"effectiveConnectionType": _effectiveConnectionType ?: RCTEffectiveConnectionTypeUnknown,

Original file line number	Diff line number	Diff line change
`@@ -164,6 +164,7 @@ - (BOOL)setReachabilityStatus:(SCNetworkReachabilityFlags)flags`
`164`	`164`	`reject:(__unused RCTPromiseRejectBlock)reject)`
`165`	`165`	`{`
`166`	`166`	`SCNetworkReachabilityRef reachability = [self getReachabilityRef];`
	`167`	`+ SCNetworkReachabilityUnscheduleFromRunLoop(reachability, CFRunLoopGetMain(), kCFRunLoopCommonModes);`
`167`	`168`	`CFRelease(reachability);`
`168`	`169`	`resolve(@{@"connectionType": _connectionType ?: RCTConnectionTypeUnknown,`
`169`	`170`	`@"effectiveConnectionType": _effectiveConnectionType ?: RCTEffectiveConnectionTypeUnknown,`