Fix TLS when using the ProxyAgent

MadLittleMods · MadLittleMods · commit b01906263409 · 2023-07-06T09:51:06.000-05:00
Same fix as #15746 Thanks to @realtyem for pointing it out! `creatorForNetloc(...)` doesn't come with typing and expects `host` to be `bytes` instead of a `str`. `ProxyAgent` was introduced with the federation outbound proxy: #15773
diff --git a/synapse/http/proxyagent.py b/synapse/http/proxyagent.py
@@ -152,7 +152,7 @@ def __init__(
 
                 if federation_proxy.tls:
                     tls_connection_creator = self._policy_for_https.creatorForNetloc(
-                        federation_proxy.host,
+                        federation_proxy.host.encode("utf-8"),
                         federation_proxy.port,
                     )
                     endpoint = wrapClientTLS(tls_connection_creator, endpoint)

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ def __init__(`
`152`	`152`
`153`	`153`	`if federation_proxy.tls:`
`154`	`154`	`tls_connection_creator = self._policy_for_https.creatorForNetloc(`
`155`		`- federation_proxy.host,`
	`155`	`+ federation_proxy.host.encode("utf-8"),`
`156`	`156`	`federation_proxy.port,`
`157`	`157`	`)`
`158`	`158`	`endpoint = wrapClientTLS(tls_connection_creator, endpoint)`