Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 687d30b

Browse files
anoadragon453anoadragon453
committed
Merge commit 'c9c544cda' into anoa/dinsic_release_1_21_x
* commit 'c9c544cda': Remove `ChainedIdGenerator`. (#8123) Switch the JSON byte producer from a pull to a push producer. (#8116) Updated docs: Added note about missing 308 redirect support. (#8120) Be stricter about JSON that is accepted by Synapse (#8106) Convert runWithConnection to async. (#8121) Remove the unused inlineCallbacks code-paths in the caching code (#8119) Separate `get_current_token` into two. (#8113) Convert events worker database to async/await. (#8071) Add a link to the matrix-synapse-rest-password-provider. (#8111)
2 parents 1e9ec2a + c9c544c commit 687d30b

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+409
-419
lines changed

‎changelog.d/8071.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Convert various parts of the codebase to async/await.

‎changelog.d/8106.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix a long-standing bug where invalid JSON would be accepted by Synapse.

‎changelog.d/8111.doc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Link to matrix-synapse-rest-password-provider in the password provider documentation.

‎changelog.d/8113.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Separate `get_current_token` into two since there are two different use cases for it.

‎changelog.d/8116.feature

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Iteratively encode JSON to avoid blocking the reactor.

‎changelog.d/8119.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Convert various parts of the codebase to async/await.

‎changelog.d/8120.doc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Updated documentation to note that Synapse does not follow `HTTP 308` redirects due to an upstream library not supporting them. Contributed by Ryan Cole.

‎changelog.d/8121.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Convert various parts of the codebase to async/await.

‎changelog.d/8123.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Remove `ChainedIdGenerator`.

‎docs/federate.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,18 @@ you invite them to. This can be caused by an incorrectly-configured reverse
4747
proxy: see [reverse_proxy.md](<reverse_proxy.md>) for instructions on how to correctly
4848
configure a reverse proxy.
4949

50+
### Known issues
51+
52+
**HTTP `308 Permanent Redirect` redirects are not followed**: Due to missing features
53+
in the HTTP library used by Synapse, 308 redirects are currently not followed by
54+
federating servers, which can cause `M_UNKNOWN` or `401 Unauthorized` errors. This
55+
may affect users who are redirecting apex-to-www (e.g. `example.com` -> `www.example.com`),
56+
and especially users of the Kubernetes *Nginx Ingress* module, which uses 308 redirect
57+
codes by default. For those Kubernetes users, [this Stackoverflow post](https://stackoverflow.com/a/52617528/5096871)
58+
might be helpful. For other users, switching to a `301 Moved Permanently` code may be
59+
an option. 308 redirect codes will be supported properly in a future
60+
release of Synapse.
61+
5062
## Running a demo federation of Synapses
5163

5264
If you want to get up and running quickly with a trio of homeservers in a

0 commit comments

Comments
 (0)