Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit 525989b

Browse files
authored
fix(fab): Adjust fab line-height (#5254)
1 parent b4cfdc4 commit 525989b

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

packages/mdc-fab/_mixins.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,9 @@ $mdc-fab-icon-enter-duration_: 180ms;
333333
width: auto;
334334
max-width: 100%;
335335
height: $mdc-fab-extended-height;
336+
// This allows the text within the extended fab to be centered for varying font sizes.
337+
/* @alternate */
338+
line-height: inherit;
336339
}
337340
}
338341

test/screenshot/golden.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -632,9 +632,9 @@
632632
}
633633
},
634634
"spec/mdc-fab/classes/extended.html": {
635-
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2019/11/01/18_25_15_143/spec/mdc-fab/classes/extended.html?utm_source=golden_json",
635+
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/esgonzalez/2019/11/14/22_24_39_633/spec/mdc-fab/classes/extended.html?utm_source=golden_json",
636636
"screenshots": {
637-
"desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2019/11/01/18_25_15_143/spec/mdc-fab/classes/extended.html.windows_chrome_77.png",
637+
"desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/esgonzalez/2019/11/14/22_24_39_633/spec/mdc-fab/classes/extended.html.windows_chrome_77.png",
638638
"desktop_windows_firefox@69": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/10/14_25_41_111/spec/mdc-fab/classes/extended.html.windows_firefox_65.png",
639639
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/07/17/22_50_36_536/spec/mdc-fab/classes/extended.html.windows_ie_11.png"
640640
}
@@ -648,17 +648,17 @@
648648
}
649649
},
650650
"spec/mdc-fab/mixins/extended-padding.html": {
651-
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2019/11/01/18_25_15_143/spec/mdc-fab/mixins/extended-padding.html?utm_source=golden_json",
651+
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/esgonzalez/2019/11/14/22_24_39_633/spec/mdc-fab/mixins/extended-padding.html?utm_source=golden_json",
652652
"screenshots": {
653-
"desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2019/11/01/18_25_15_143/spec/mdc-fab/mixins/extended-padding.html.windows_chrome_77.png",
653+
"desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/esgonzalez/2019/11/14/22_24_39_633/spec/mdc-fab/mixins/extended-padding.html.windows_chrome_77.png",
654654
"desktop_windows_firefox@69": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/10/14_25_41_111/spec/mdc-fab/mixins/extended-padding.html.windows_firefox_65.png",
655655
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/advorak/2018/07/17/22_50_36_536/spec/mdc-fab/mixins/extended-padding.html.windows_ie_11.png"
656656
}
657657
},
658658
"spec/mdc-fab/mixins/extended-shape-radius.html": {
659-
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2019/11/01/18_25_15_143/spec/mdc-fab/mixins/extended-shape-radius.html?utm_source=golden_json",
659+
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/esgonzalez/2019/11/14/22_24_39_633/spec/mdc-fab/mixins/extended-shape-radius.html?utm_source=golden_json",
660660
"screenshots": {
661-
"desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2019/11/01/18_25_15_143/spec/mdc-fab/mixins/extended-shape-radius.html.windows_chrome_77.png",
661+
"desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/esgonzalez/2019/11/14/22_24_39_633/spec/mdc-fab/mixins/extended-shape-radius.html.windows_chrome_77.png",
662662
"desktop_windows_firefox@69": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/05/10/14_25_41_111/spec/mdc-fab/mixins/extended-shape-radius.html.windows_firefox_65.png",
663663
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2018/11/13/20_59_35_867/spec/mdc-fab/mixins/extended-shape-radius.html.windows_ie_11.png"
664664
}
@@ -1120,9 +1120,9 @@
11201120
}
11211121
},
11221122
"spec/mdc-shape/variables/override.html": {
1123-
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2019/11/01/18_25_15_143/spec/mdc-shape/variables/override.html?utm_source=golden_json",
1123+
"public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/esgonzalez/2019/11/14/22_24_39_633/spec/mdc-shape/variables/override.html?utm_source=golden_json",
11241124
"screenshots": {
1125-
"desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2019/11/01/18_25_15_143/spec/mdc-shape/variables/override.html.windows_chrome_77.png",
1125+
"desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/esgonzalez/2019/11/14/22_24_39_633/spec/mdc-shape/variables/override.html.windows_chrome_77.png",
11261126
"desktop_windows_firefox@69": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2019/11/01/18_25_15_143/spec/mdc-shape/variables/override.html.windows_firefox_69.png",
11271127
"desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/abhiomkar/2019/11/01/18_25_15_143/spec/mdc-shape/variables/override.html.windows_ie_11.png"
11281128
}

0 commit comments

Comments
 (0)