Fixed undefined behavior with log10 cast of fractional doubles (#276)

mikael-s-persson · web-flow · commit 708fff700f36 · 2025-06-11T03:45:26.000+03:00
diff --git a/include/toml++/impl/toml_formatter.inl b/include/toml++/impl/toml_formatter.inl
@@ -91,7 +91,7 @@ TOML_ANON_NAMESPACE_START
 					weight += 1u;
 					val *= -1.0;
 				}
-				return weight + static_cast<size_t>(log10(val)) + 1u;
+				return weight + static_cast<size_t>(abs(log10(val))) + 1u;
 			}
 
 			case node_type::boolean: return 5u;
diff --git a/toml.hpp b/toml.hpp
@@ -17107,7 +17107,7 @@ TOML_ANON_NAMESPACE_START
 					weight += 1u;
 					val *= -1.0;
 				}
-				return weight + static_cast<size_t>(log10(val)) + 1u;
+				return weight + static_cast<size_t>(abs(log10(val))) + 1u;
 			}
 
 			case node_type::boolean: return 5u;

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ TOML_ANON_NAMESPACE_START`
`91`	`91`	`weight += 1u;`
`92`	`92`	`val *= -1.0;`
`93`	`93`	`}`
`94`		`- return weight + static_cast<size_t>(log10(val)) + 1u;`
	`94`	`+ return weight + static_cast<size_t>(abs(log10(val))) + 1u;`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`case node_type::boolean: return 5u;`
Original file line number	Diff line number	Diff line change
`@@ -17107,7 +17107,7 @@ TOML_ANON_NAMESPACE_START`
`17107`	`17107`	`weight += 1u;`
`17108`	`17108`	`val *= -1.0;`
`17109`	`17109`	`}`
`17110`		`- return weight + static_cast<size_t>(log10(val)) + 1u;`
	`17110`	`+ return weight + static_cast<size_t>(abs(log10(val))) + 1u;`
`17111`	`17111`	`}`
`17112`	`17112`
`17113`	`17113`	`case node_type::boolean: return 5u;`