Skip to content

Commit 066acda

Browse files
committed
further corrections to tests
1 parent 800a8e6 commit 066acda

File tree

1 file changed

+6
-5
lines changed
  • tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions

1 file changed

+6
-5
lines changed

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ToCharTest.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
namespace Tests\Integration\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions;
66

77
use Doctrine\DBAL\Exception;
8+
use Doctrine\DBAL\Exception\DriverException;
89
use Doctrine\ORM\Query\QueryException;
910
use MartinGeorgiev\Doctrine\ORM\Query\AST\Functions\ToChar;
1011
use MartinGeorgiev\Doctrine\ORM\Query\AST\Functions\ToTimestamp;
@@ -15,6 +16,7 @@ class ToCharTest extends TestCase
1516
protected function setUp(): void
1617
{
1718
parent::setUp();
19+
$this->createTestSchema();
1820
$this->createContainsDatesTableWithFixture();
1921
$this->createContainsNumericsTableWithFixture();
2022
}
@@ -69,14 +71,14 @@ public function test_tochar_with_subfunction(): void
6971
static::assertSame('11:55:32', $result[0]['result']);
7072
}
7173

72-
public function test_todate_throws_with_invalid_input(): void
74+
public function test_tochar_throws_with_invalid_input_type(): void
7375
{
74-
$this->expectException(QueryException::class);
75-
$dql = "SELECT to_date('invalid_date', 'DD Mon YYYY') AS result FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsTexts t WHERE t.id = 1";
76+
$this->expectException(DriverException::class);
77+
$dql = "SELECT to_char('can only be timestamp, interval or numeric, never a string', 'DD Mon YYYY') AS result FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsDates t WHERE t.id = 1";
7678
$this->executeDqlQuery($dql);
7779
}
7880

79-
public function test_todate_throws_with_invalid_format(): void
81+
public function test_tochar_throws_with_invalid_format(): void
8082
{
8183
$this->expectException(Exception::class);
8284
$dql = "SELECT to_char(t.decimal1, 'invalid_format') FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsNumerics t WHERE t.id = 1";
@@ -94,7 +96,6 @@ private function createContainsDatesTableWithFixture(): void
9496
{
9597
$tableName = 'containsdates';
9698

97-
$this->createTestSchema();
9899
$this->dropTestTableIfItExists($tableName);
99100

100101
$fullTableName = \sprintf('%s.%s', self::DATABASE_SCHEMA, $tableName);

0 commit comments

Comments
 (0)