fixed classification requirements

manishamde · manishamde · commit ed5a2dffbf3e · 2014-05-12T20:45:22.000-07:00
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala b/mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala
@@ -1093,9 +1093,9 @@ object DecisionTree extends Serializable with Logging {
      */
     if (strategy.categoricalFeaturesInfo.size > 0) {
       val maxCategoriesForFeatures = strategy.categoricalFeaturesInfo.maxBy(_._2)._2
-      require(numBins >= maxCategoriesForFeatures)
+      require(numBins > maxCategoriesForFeatures)
       if (strategy.isMultiClassification) {
-        require(numBins > math.pow(2, maxCategoriesForFeatures.toInt) - 1)
+        require(numBins > math.pow(2, maxCategoriesForFeatures.toInt - 1) - 1)
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1093,9 +1093,9 @@ object DecisionTree extends Serializable with Logging {`
`1093`	`1093`	`*/`
`1094`	`1094`	`if (strategy.categoricalFeaturesInfo.size > 0) {`
`1095`	`1095`	`val maxCategoriesForFeatures = strategy.categoricalFeaturesInfo.maxBy(_._2)._2`
`1096`		`- require(numBins >= maxCategoriesForFeatures)`
	`1096`	`+ require(numBins > maxCategoriesForFeatures)`
`1097`	`1097`	`if (strategy.isMultiClassification) {`
`1098`		`- require(numBins > math.pow(2, maxCategoriesForFeatures.toInt) - 1)`
	`1098`	`+ require(numBins > math.pow(2, maxCategoriesForFeatures.toInt - 1) - 1)`
`1099`	`1099`	`}`
`1100`	`1100`	`}`
`1101`	`1101`