Skip to content

Commit 79084e8

Browse files
committed
Update Master.scala
1 parent 1daf25f commit 79084e8

File tree

1 file changed

+8
-13
lines changed
  • core/src/main/scala/org/apache/spark/deploy/master

1 file changed

+8
-13
lines changed

core/src/main/scala/org/apache/spark/deploy/master/Master.scala

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ private[master] class Master(
554554
private[master] def scheduleExecutorsOnWorkers(
555555
app: ApplicationInfo,
556556
usableWorkers: Array[WorkerInfo],
557-
spreadOutApps: Boolean): Option[Array[Int]] = {
557+
spreadOutApps: Boolean): Array[Int] = {
558558
// If the number of cores per executor is not specified, then we can just schedule
559559
// 1 core at a time since we expect a single executor to be launched on each worker
560560
val coresPerExecutor = app.desc.coresPerExecutor.getOrElse(1)
@@ -577,8 +577,7 @@ private[master] class Master(
577577
pos = (pos + 1) % numUsable
578578
if (pos == 0) {
579579
if (lastCoresToAssign == coresToAssign) {
580-
logError("Not enough resources to schedule executors, please check configuration")
581-
return None
580+
return assignedCores
582581
}
583582
lastCoresToAssign = coresToAssign
584583
}
@@ -596,14 +595,13 @@ private[master] class Master(
596595
pos = (pos + 1) % numUsable
597596
if (pos == 0) {
598597
if (lastCoresToAssign == coresToAssign) {
599-
logError("Not enough resources to schedule executors, please check configuration")
600-
return None
598+
return assignedCores
601599
}
602600
lastCoresToAssign = coresToAssign
603601
}
604602
}
605603
}
606-
Some(assignedCores)
604+
assignedCores
607605
}
608606

609607
/**
@@ -619,15 +617,12 @@ private[master] class Master(
619617
.filter(worker => worker.memoryFree >= app.desc.memoryPerExecutorMB &&
620618
worker.coresFree >= coresPerExecutor.getOrElse(1))
621619
.sortBy(_.coresFree).reverse
622-
val assignedCores_ = scheduleExecutorsOnWorkers(app, usableWorkers, spreadOutApps)
620+
val assignedCores = scheduleExecutorsOnWorkers(app, usableWorkers, spreadOutApps)
623621

624622
// Now that we've decided how many cores to allocate on each worker, let's allocate them
625-
if (assignedCores_ != None) {
626-
val assignedCores = assignedCores_.get
627-
for (pos <- 0 until usableWorkers.length if assignedCores(pos) > 0) {
628-
allocateWorkerResourceToExecutors(
629-
app, assignedCores(pos), coresPerExecutor, usableWorkers(pos))
630-
}
623+
for (pos <- 0 until usableWorkers.length if assignedCores(pos) > 0) {
624+
allocateWorkerResourceToExecutors(
625+
app, assignedCores(pos), coresPerExecutor, usableWorkers(pos))
631626
}
632627
}
633628
}

0 commit comments

Comments
 (0)